Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept calculated value in CSS colors #1448

Merged
merged 39 commits into from
Jul 11, 2023
Merged

Accept calculated value in CSS colors #1448

merged 39 commits into from
Jul 11, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 10, 2023

Part of #1202.

Jym77 added 30 commits July 4, 2023 15:32
@Jym77
Add HasCalculation type helper
fce72f0
@Jym77
Make CALC parameter boolean in Color
e644090
@Jym77
Workaround
e96342f
@Jym77
Rename files
6bd1b29
@Jym77
Improve RGB tests
7ab0267
@Jym77
Streamline parsers
1ee393d
@Jym77
Modernise parsers
7046d47
@Jym77
Accept none in modern RGB syntax
0f2125f
@Jym77
Correctly resolve RGB colors
4f575a0
@Jym77
Pre-resolve calculations in colors
c685d35
@Jym77
Accept calculations in RGB colors
1026dee
@Jym77
Revert "Accept calculations in RGB colors"
2207d2b 
This reverts commit 1026dee.
@Jym77
Revert "Pre-resolve calculations in colors"
52cf9d8 
This reverts commit c685d35.
@Jym77
Keep format colors as non-calculated
685edda
@Jym77
Pre-resolve numbers when building RGB
8252061
@Jym77
Improve typing
607b6e6
@Jym77
Work around type instantiation limit
6f73cfa
@Jym77
Accept calculations in RGB colors
7bae238
@Jym77
Add calculation tests
87b0476
@Jym77
Add named color tests
4de5dd8
@Jym77
Add abstract channel getters
3b3f78d
@Jym77
resolve colors to RBG
4cab4a6
@Jym77
Add some HSL tests
3e6655f
@Jym77
Modernise parsers
2484eb0
@Jym77
Accept none in modern HSL syntax
187c500
@Jym77
Fix parser and tests
f266e9a
@Jym77
Accept calculated HSL colors
cef8e62
@Jym77
Correctly resolve HSL colors
95c3b98
@Jym77
Clean up helper functionss
5b16095
@Jym77
Add correct shadow resolving method
6816b11
@Jym77 Jym77 self-assigned this Jul 10, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Jul 10, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 10, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review July 10, 2023 08:37
@Jym77 Jym77 requested review from a team and rcj-siteimprove July 10, 2023 08:37
rcj-siteimprove
rcj-siteimprove previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Jym77
Copy link
Contributor Author

Jym77 commented Jul 11, 2023

!pr extract

@Jym77 Jym77 enabled auto-merge July 11, 2023 12:29
@Jym77 Jym77 requested a review from rcj-siteimprove July 11, 2023 14:04
@Jym77 Jym77 added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit 42e0e4a Jul 11, 2023
@Jym77 Jym77 deleted the color-calculated branch July 11, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove