SIA-R19: fix regression #1459
Merged
SIA-R19: fix regression #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvy-siteimprove
approved these changes
Aug 9, 2023
Jym77
added a commit
that referenced
this pull request
Aug 9, 2023
* Add breaking test * Improve documentation * Correctly search for id in the full tree * Update documentation * Add changeset
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Extract position to its own folder * Move Offset to its own file * Move Keywords and Side to their own files * Move Component to its own file * Remove Offset and use LengthPercentage directly * Make Side somewhat calculatable * Switch parameter order * Prepare partial resolving * Make Component always take a Side * Add missing changeset * Make offest optional in Side.of * Make offset optional or Option in Side.of * Add partial resolver, rework type parameters * Make Position calculatable * Add some parsing examples with calculations * Add some resolving examples with calculations * Resolve percentages separatly in each dimension * Add changeset * Clean up * Extract API * Clean up * Typo * Extract API * Add Resolvable implementation * Extract API * Calculatable `Shadow` (#1455) * Typo * Add some package implementation details * Streamline code * Streamline parser * Clean up test indentation * Add some shadow teest * Eport Option interface * Add more shadow parsing tests * Add a resolve test * Make Shadow calculatable * Add changesets * Extract API * Typos * Clean up * Actually accept calculations * Add Value.hasCalculation helper * Rename parameter * Extract API --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Calculatable `transform` functions (#1457) * Streamline parsers * Clean up * Share parsers in tests * Add Matrix parsing tests * Simplify Matrix parser * Improve parseIf * Improve parser * Add tests for Rotate prasing * Add tests for Rotate prasing * Simplify parser * Simplify parser * Add Scale parsing tests * Simplify Scale parser * Simplify parsers * Add Skew parsing tests * Simplify Skew parsers * Add Translate tests * Simplify parsers * Clean up * Extract API * Typos * Make translate Function calculatable * Make matrix calculatable * Make matrix calculatable * Streamline Perspective * Make Perspective calculatable * Make Rotate calculatable * Add calculated rotate tests * Add calculated rotate tests * Make Scale calculatable * Accept calculation in Skew * Make Translate calculatable * Accept calculation in all transform function * Clean up * Extract API * Clean up * Extract API * Fix type inferrence * Extract API --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * SIA-R19: fix regression (#1459) * Add breaking test * Improve documentation * Correctly search for id in the full tree * Update documentation * Add changeset * v0.66.0 * Remove duplicate variable --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: siteimprove-builduser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #1413 we accidentally started searching for IDs in the subtree of the element, rather than its full tree (going to the root).
Fixing it.