Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style cleanup #1510

Merged
merged 16 commits into from
Nov 28, 2023
Merged

Style cleanup #1510

merged 16 commits into from
Nov 28, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Nov 23, 2023 •
edited
Loading

Resolves #1202 🎉

Use Resolvable interface everywhere.
Clean up some leftover in alfa-style.

@Jym77 Jym77 self-assigned this Nov 23, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Nov 23, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Nov 23, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review November 23, 2023 15:36
@Jym77 Jym77 requested a review from a team as a code owner November 23, 2023 15:36
@Jym77 Jym77 enabled auto-merge November 23, 2023 15:36
rcj-siteimprove
rcj-siteimprove approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@Jym77 Jym77 added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 75adbe4 Nov 28, 2023
@Jym77 Jym77 deleted the style-cleanup branch November 28, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support calc() expressions in all properties
2 participants
@Jym77 @rcj-siteimprove