Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SkyWalking.NetworkProtocol project #1

Merged
merged 4 commits into from
Feb 11, 2018
Merged

Add SkyWalking.NetworkProtocol project #1

merged 4 commits into from
Feb 11, 2018

Conversation

liuhaoyang
Copy link
Collaborator

@liuhaoyang liuhaoyang requested a review from wu-sheng February 9, 2018 16:48
@liuhaoyang
Copy link
Collaborator Author

liuhaoyang commented Feb 9, 2018 •
edited
Loading

@wu-sheng This is my first pr, it just adds protos and generate csharp files. I will continue to design the structure of APMCore.

wu-sheng
wu-sheng reviewed Feb 10, 2018
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should add a CONTIBUTING.md about how to generate proto source codes? In further, we will tell community about how to rebuild the project?

@wu-sheng
Copy link
Member

Others look good to me.

@wu-sheng
Copy link
Member

Another suggestion is: Update README.md to guide interested prople to join our gitter? and License, related project, etc.

All these to help people know that, we are actually building SkyWalking-C# agent.

@geffzhang geffzhang mentioned this pull request Feb 10, 2018
Closed
@wu-sheng wu-sheng added this to the 0.1 milestone Feb 10, 2018
@wu-sheng wu-sheng added enhancement New feature or request next version labels Feb 10, 2018
@wu-sheng wu-sheng requested a review from misaya February 10, 2018 12:26
@misaya misaya merged commit 832da76 into SkyAPM:master Feb 11, 2018
This was referenced Feb 11, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@misaya misaya misaya approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@liuhaoyang @wu-sheng @misaya