Refactor tracing context #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is in progress, please do not merge first. I will redesign the api of the tracing context, which will be a tedious task. In order to facilitate the code review, I opened this PR in advance. |
|
Got it. Take your time. |
# Conflicts: # src/SkyWalking.Abstractions/Transport/V5/ISkyWalkingClientV5.cs # src/SkyWalking.Agent.AspNetCore/Extensions/ServiceCollectionExtensions.cs # src/SkyWalking.AspNet/Extensions/ServiceCollectionExtensions.cs # src/SkyWalking.Core/Context/Trace/TraceSegmentRef.cs # src/SkyWalking.Core/Service/SegmentReportService.cs # src/SkyWalking.Transport.Grpc/Utils/SegmentV5Helpers.cs # src/SkyWalking.Transport.Grpc/V6/SegmentReporter.cs
|
CI has been repaired. |
liuhaoyang
commented
Feb 12, 2019
There was a problem hiding this comment.
Supprot #57 . Users can choose counting-based or percentage-based sampling, or use both of them at the same time.
liuhaoyang
commented
Feb 13, 2019
|
Fix #121, support concurrent operation |
|
It’s really exciting. The core functionality of v0.8 has been completed. |
ElderJames
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
在使用 await Task.WhenAll 发起http请求时，偶尔抛出 No active span 异常 #102
Every possible cross-threaded ExitSpan, as a new traceSegment
New feature or improvement
Redesign the tracing context api to support asp.net and wcf