Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Microsoft ILogger interface to push logs to skywalking #502

Merged
merged 3 commits into from
Sep 4, 2022
Merged

Implement the Microsoft ILogger interface to push logs to skywalking #502

merged 3 commits into from
Sep 4, 2022

Conversation

KawhiWei
Copy link
Contributor

@KawhiWei KawhiWei commented Sep 3, 2022

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • [ x ] New feature provided

New feature or improvement

  • Implement the Microsoft ILogger interface to push logs to skywalking

@wu-sheng wu-sheng requested a review from liuhaoyang September 3, 2022 12:53
@wu-sheng wu-sheng added this to the 2.1.0 milestone Sep 3, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Sep 3, 2022
@wu-sheng
Copy link
Member

wu-sheng commented Sep 3, 2022

Please update readme docs about this new feature. And whether this plugin requires extra steps to setup? Please update docs about that as well.

@liuhaoyang liuhaoyang merged commit 7b3119d into SkyAPM:master Sep 4, 2022
@liuhaoyang liuhaoyang mentioned this pull request Sep 11, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuhaoyang liuhaoyang liuhaoyang approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KawhiWei @wu-sheng @liuhaoyang