Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor MSLogging extensions and add log samples #513

Merged
merged 3 commits into from
Sep 19, 2022
Merged

refactor MSLogging extensions and add log samples #513

merged 3 commits into from
Sep 19, 2022

Conversation

liuhaoyang
Copy link
Collaborator

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

@liuhaoyang liuhaoyang requested a review from wu-sheng September 18, 2022 15:34
wu-sheng
wu-sheng approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am feeling dot net agent should provide a more detailed doc to guide users.

@liuhaoyang
Copy link
Collaborator Author

I am feeling dot net agent should provide a more detailed doc to guide users.

yes, will do this next

@liuhaoyang liuhaoyang merged commit 6dd8c10 into SkyAPM:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuhaoyang @wu-sheng