Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up to .net7 #532

Merged
merged 9 commits into from
Feb 1, 2023
Merged

up to .net7 #532

merged 9 commits into from
Feb 1, 2023

Conversation

joesdu
Copy link
Contributor

@joesdu joesdu commented Jan 4, 2023

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues
    NET 7 support
    Update related dependencies to the latest
    Fix dependency issues with CAP related libraries.Newtonsoft.Json → Text.Json
    支持.NET 7
    更新相关依赖到最新
    修复CAP相关库的依赖问题.将Newtonsoft.Json更换到Text.Json


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@wu-sheng wu-sheng requested a review from liuhaoyang January 4, 2023 06:53
@liuhaoyang
Copy link
Collaborator

@joesdu There seems to be something wrong with the github action check, can you fix it ?

@joesdu
Copy link
Contributor Author

joesdu commented Jan 13, 2023

@joesdu There seems to be something wrong with the github action check, can you fix it ?

OK

@joesdu
Copy link
Contributor Author

joesdu commented Jan 13, 2023

😟GitHub action好像被我搞卡死了,先看会动漫,明天再瞅瞅.

@wu-sheng
Copy link
Member

No, you don't break anything. This is your first contribution, so, the CI is waiting for maintainer's approval.

@joesdu
Copy link
Contributor Author

joesdu commented Jan 14, 2023

已将.net 6和.net7的CI分开, .NET6会无法编译支持.NET7的项目.

@wu-sheng
Copy link
Member

@liuhaoyang Any suggestion?

@liuhaoyang
Copy link
Collaborator

@liuhaoyang Any suggestion?

@joesdu 尝试在 NET6 的 CI中指定 framework 参数?

@joesdu
Copy link
Contributor Author

joesdu commented Jan 17, 2023

@liuhaoyang Any suggestion?

@joesdu 尝试在 NET6 的 CI中指定 framework 参数?
按照楼上的意思是将.NET6和7的CI分开,但是分开的话.NET6就无法编译支持.NET7的库,其实.NET7的SDK打包的包也可以支持.NET6,所以我觉得分开其实没有意义.

@liuhaoyang
Copy link
Collaborator

@liuhaoyang Any suggestion?

@joesdu 尝试在 NET6 的 CI中指定 framework 参数?
按照楼上的意思是将.NET6和7的CI分开,但是分开的话.NET6就无法编译支持.NET7的库,其实.NET7的SDK打包的包也可以支持.NET6,所以我觉得分开其实没有意义.

如果.NET6的CI没法编译,那.NET6的项目是不是也会有问题?这个还是要解决的

@joesdu
Copy link
Contributor Author

joesdu commented Jan 25, 2023

如果.NET6的CI没法编译,那.NET6的项目是不是也会有问题?这个还是要解决的

.NET6 没有问题.因为.NET7的CI在编译多框架支持的库的时候,也会打包.NET6的库.
image
比如我这两个库均是使用.NET7的SDK编译的,支持了.NET6的Target后,在.NET6的项目中依然可以正常使用.

@liuhaoyang
Copy link
Collaborator

如果.NET6的CI没法编译,那.NET6的项目是不是也会有问题?这个还是要解决的

.NET6 没有问题.因为.NET7的CI在编译多框架支持的库的时候,也会打包.NET6的库. image 比如我这两个库均是使用.NET7的SDK编译的,支持了.NET6的Target后,在.NET6的项目中依然可以正常使用.

看起来这个问题是 dotnet restore 命令设计的问题。我把 net6 的 required 取消了,把 net6 的 CI 移除看上去是唯一的方案了

@liuhaoyang liuhaoyang merged commit 1bc1ce8 into SkyAPM:main Feb 1, 2023
@wu-sheng
Copy link
Member

wu-sheng commented Feb 1, 2023

@liuhaoyang Should we update relative docs for compiling(.net 7 required) and the runtime support env list?

1 similar comment
@wu-sheng
Copy link
Member

wu-sheng commented Feb 1, 2023

@liuhaoyang Should we update relative docs for compiling(.net 7 required) and the runtime support env list?

@liuhaoyang
Copy link
Collaborator

@liuhaoyang Should we update relative docs for compiling(.net 7 required) and the runtime support env list?

i will do .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants