log db statement with parameter value when use SmartSql #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Feb 16, 2023
| @@ -249,7 +250,12 @@ public void BeforeCommandExecuterExecute([Object]CommandExecuterExecuteBeforeEve | |||
| var context = CreateSmartSqlLocalSegmentContext(eventData.Operation); | |||
| if (eventData.ExecutionContext.Request.RealSql != null) | |||
| { | |||
| context.Span.AddTag(Common.Tags.DB_STATEMENT, eventData.ExecutionContext.Request.RealSql); | |||
| //context.Span.AddTag(Common.Tags.DB_STATEMENT, eventData.ExecutionContext.Request.RealSql); | |||
There was a problem hiding this comment.
Below varialbe "sql" include "RealSql"
for example:
ReqlSql="select 1 from T where F1=@F1"
sql="selece 1 from T where F1='aaa'"
So it's no need to log RealSql
There was a problem hiding this comment.
I mean if you try to delete this, delete this. Git is the time machine. We don't need to keep old codes.
There was a problem hiding this comment.
Recommit pr after I delete it?
There was a problem hiding this comment.
Yes, if your plan is to remove this line.
|
Let's wait for @liuhaoyang to review other details. |
liuhaoyang
approved these changes
Feb 19, 2023
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
New feature provided
Related issues
Can't log parameter values
New feature or improvement