Validate topic names #103
Merged
Validate topic names #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviews in this chain: |
|
jerry-skydio
force-pushed
the
jerry/revup/main/catch1-./Q
branch
2 times, most recently
from
23ec53a to
9736a98
Compare
brian-kubisiak-skydio
approved these changes
Apr 4, 2023
revup/topic_stack.py
Outdated
| @@ -54,6 +54,8 @@ def format_remote_branch(uploader: str, base_branch: str, topic: str) -> str: | |||
|
|
|||
| RE_COMMIT_LABEL = re.compile(r"^(?P<label1>[a-zA-Z\-_0-9]+):.*|^\[(?P<label2>[a-zA-Z\-_0-9]+)\].*") | |||
|
|
|||
| RE_BRANCH_ALLOWED = re.compile(r"^[a-zA-Z\d_\.\/-]+$") | |||
There was a problem hiding this comment.
\w instead of a-zA-Z\d so unicode can be used
Also, comment on where this restriction comes from (valid branch names?)
There was a problem hiding this comment.
hmm i haven't tested with unicode but let me try that
There was a problem hiding this comment.
hmm github doesn't seem super happy but it did work #106 so i'll go with this
jerry-skydio
force-pushed
the
jerry/revup/main/catch1-./Q
branch
2 times, most recently
from
2e2dd00 to
e844f7d
Compare
Catch the common case of someone sticking an invalid char in the topic line. Topic: catch1-./Q Reviewers: brian-k
jerry-skydio
force-pushed
the
jerry/revup/main/catch1-./Q
branch
2 times, most recently
from
5fa08e8 to
e45db27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch the common case of someone sticking an invalid char in the topic
line.
Topic: catch1-./Q
Reviewers: brian-k