Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and warn on github timeouts #114

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

jerry-skydio
Copy link
Collaborator

Its pretty common for us to hit the 10s github
timeout for very large graphql mutations. In pretty
much all of these cases though, the actual changes
in the request did go through, and a subsequent
revup upload will show everything up to date.

To reflect this and make it nicer for users, catch any
github exception that contains 'timeout' and turn it
into a warning instead. This ensures that we show the topic
list. If the user wishes, they can rerun the command to
verify the changes were actually successful.

Topic: githubtimeout
Reviewers: aaron, brian-k

@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
#114 Catch and warn on github timeouts

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Apr 14, 2023

# head base diff date summary
0 1a9feb29 92bd9efb diff Apr 13 19:17 PM 3 files changed, 26 insertions(+), 17 deletions(-)
1 7d701a07 7ca78675 diff Apr 18 19:20 PM 1 file changed, 7 insertions(+), 3 deletions(-)
2 9f73e92c 7ca78675 diff Apr 18 19:23 PM 1 file changed, 1 insertion(+), 1 deletion(-)

revup/types.py Outdated Show resolved Hide resolved
Copy link
Contributor

@aaron-skydio aaron-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/githubtimeout branch from 1a9feb2 to 7d701a0 Compare April 19, 2023 02:20
Its pretty common for us to hit the 10s github
timeout for very large graphql mutations. In pretty
much all of these cases though, the actual changes
in the request did go through, and a subsequent
revup upload will show everything up to date.

To reflect this and make it nicer for users, catch any
github exception that contains 'timeout' and turn it
into a warning instead. This ensures that we show the topic
list. If the user wishes, they can rerun the command to
verify the changes were actually successful.

Topic: githubtimeout
Reviewers: aaron, brian-k
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/githubtimeout branch from 7d701a0 to 9f73e92 Compare April 19, 2023 02:23
@jerry-skydio jerry-skydio merged commit 62ef6d3 into main Apr 19, 2023
@jerry-skydio jerry-skydio deleted the jerry/revup/main/githubtimeout branch April 19, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants