Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: Fix broken mypy linting on asyncio.gather() #134

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

jerry-skydio
Copy link
Collaborator

This used to work but somehow got broken by a mypy
version upgrade. Now the output of gather is treated
as a list and as a result type info by index is not
preserved. We have to manually declare the types by
asserting for it to be happy.

This used to work but somehow got broken by a mypy
version upgrade. Now the output of gather is treated
as a list and as a result type info by index is not
preserved. We have to manually declare the types by
asserting for it to be happy.
@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
#134 shell: Fix broken mypy linting on asyncio.gather()

@jerry-skydio
Copy link
Collaborator Author

# head base diff date summary
0 e8daeef8 9bfa7fb9 diff Dec 22 15:28 PM 1 file changed, 9 insertions(+), 2 deletions(-)

@jerry-skydio jerry-skydio merged commit d982a75 into main Dec 22, 2023
1 of 4 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/fixlint branch December 22, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant