amend: respect core.commentChar #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviews in this chain: |
|
jerry-skydio
force-pushed
the
jerry/revup/main/cleanup
branch
from
a3fc421 to
1c17503
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/comment
branch
from
333a4c4 to
4429d17
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/cleanup
branch
from
1c17503 to
ef0f540
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/comment
branch
from
4429d17 to
d497a62
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/cleanup
branch
from
ef0f540 to
417a57f
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/comment
branch
from
d497a62 to
e5b2e24
Compare
aaron-skydio
approved these changes
Mar 12, 2024
Comment on lines
-51
to
+56
| comments = f"\n{CLEANUP_STRIP_COMMENT}\n{comments}" | ||
| comments = f"\n{CLEANUP_STRIP_COMMENT.format(comment_char)}\n{comments}" |
There was a problem hiding this comment.
Format in an interpolated string is kinda wild, but I can't think of a nicer way lol
jerry-skydio
force-pushed
the
jerry/revup/main/cleanup
branch
from
417a57f to
56a4716
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/comment
branch
from
e5b2e24 to
9282fd7
Compare
Similarly we can respect the configured comment character pretty easily by using it instead of # when applicable.
jerry-skydio
force-pushed
the
jerry/revup/main/comment
branch
from
9282fd7 to
4875af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly we can respect the configured comment character
pretty easily by using it instead of # when applicable.