-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload: Allow arbitrary topic order #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Mar 12, 2024
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 12, 2024 21:48
f2506f1
to
2c810f3
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
from
March 12, 2024 21:49
91d3c78
to
e443136
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
3 times, most recently
from
March 12, 2024 22:05
06778e6
to
5732850
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
from
March 12, 2024 22:08
0a455aa
to
b056a29
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
3 times, most recently
from
March 12, 2024 22:17
fd95dd8
to
bc4eeaa
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
2 times, most recently
from
March 12, 2024 22:21
09150f0
to
04de160
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 12, 2024 22:21
bc4eeaa
to
58d26e7
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 12, 2024 22:26
58d26e7
to
a2975ed
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
2 times, most recently
from
March 12, 2024 22:28
95840c7
to
30b1499
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 12, 2024 22:28
a2975ed
to
ed750a8
Compare
aaron-skydio
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 13, 2024 17:59
ed750a8
to
b48ebf4
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
from
March 13, 2024 17:59
30b1499
to
250ab20
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 13, 2024 19:00
b48ebf4
to
2d8cc8e
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
from
March 13, 2024 19:00
250ab20
to
d3a9775
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
from
March 13, 2024 19:04
d3a9775
to
6c701b7
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 13, 2024 19:04
2d8cc8e
to
65cc1b5
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 13, 2024 20:41
65cc1b5
to
f3f012a
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
2 times, most recently
from
March 13, 2024 20:47
5d08aab
to
eea4724
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
2 times, most recently
from
March 13, 2024 20:51
1d3dfa1
to
79d040b
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/toptop
branch
from
March 13, 2024 20:51
eea4724
to
0111295
Compare
Now that we're iterating over topics topologically in the important places, we can remove the check that requires topics to be in consecutive order. This means revup is able to pull together relative chains in any arbitrary order, as long as that order is valid with no cycles. Fixes: #156
jerry-skydio
force-pushed
the
jerry/revup/main/anyorder
branch
from
March 13, 2024 21:03
79d040b
to
9a5a6e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're iterating over topics topologically
in the important places, we can remove the check
that requires topics to be in consecutive order.
This means revup is able to pull together relative
chains in any arbitrary order, as long as that order
is valid with no cycles.
Fixes: #156