Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: Don't crash if github bot is a reviewer #181

Merged
merged 1 commit into from
Jul 2, 2024
Merged

github: Don't crash if github bot is a reviewer #181

merged 1 commit into from
Jul 2, 2024

Conversation

jerry-skydio
Copy link
Collaborator

@jerry-skydio jerry-skydio commented Jul 2, 2024 •
edited
Loading

Bots apparently don't have a "login" field.

Topic: ghbot
Fixes: #178

@jerry-skydio
github: Don't crash if github bot is a reviewer
2ab533d 
Bots apparently don't have a "login" field.

Topic: ghbot
Fixes: #178
@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
└#181 github: Don't crash if github bot is a reviewer

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Jul 2, 2024 •
edited
Loading

# head base diff date summary
0 cb4ed7a6 71ca5eb4 diff Jul 2 12:04 PM 1 file changed, 2 insertions(+), 1 deletion(-)
1 2ab533dd 71ca5eb4 diff Jul 2 12:05 PM 0 files changed

@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/ghbot branch from cb4ed7a to 2ab533d Compare July 2, 2024 19:05
@jerry-skydio jerry-skydio merged commit e96542d into main Jul 2, 2024
5 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/ghbot branch July 2, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: login in github_utils adding author
1 participant
@jerry-skydio