-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command revup commit #52
Add a command revup commit #52
Conversation
Reviews in this chain: |
|
as is this will result in a commit inserted 1 below the top commit rather than at the top. I can make a patch that fixes this since the original ordering of --insert was arbitrary anyway |
can you squash all the commits in this pr into one? you can use revup amend ;) |
Sure thing. Out of curiosity, why not squash merge from github? |
fd53d70
to
77e26d6
Compare
there are some cases where we wouldn't want a blanket squash -- such as large changes that touch multiple area or are done in multiple stages. the other reason is that the user can do a better job of cleaning up commit messages after the squash. github just slaps them all together |
relatedly as part of squashing can you clean up the commit message to be more descriptive of the changes? Unless the change is totally trivial its good to have a few sentances describing how and why its done. see the history of the repo for some examples |
This command is an alias to "revup amend --insert" Topic: revup_commit
77e26d6
to
4e64609
Compare
This command is an alias to "revup amend --insert"
Topic: revup_commit