Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: Fixes for windows #68

Merged
merged 1 commit into from
Oct 11, 2022
Merged

shell: Fixes for windows #68

merged 1 commit into from
Oct 11, 2022

Conversation

jerry-skydio
Copy link
Collaborator

Switch to using a windows compatible "which"
function and properly catch the error if "man" is
not found.

Topic: win
Reviewers: brian-k
Fixes: 66

@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
#68 shell: Fixes for windows

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Oct 10, 2022

# head base diff date summary
0 34f3ceeb aa41c582 diff Oct 10 11:26 AM 2 files changed, 9 insertions(+), 3 deletions(-)
1 4d13407c aa41c582 diff Oct 10 11:30 AM 2 files changed, 7 insertions(+), 6 deletions(-)

Switch to using a windows compatible "which"
function and properly catch the error if "man" is
not found.

Topic: win
Reviewers: brian-k
Fixes: 66
@jerry-skydio jerry-skydio merged commit 661636d into main Oct 11, 2022
@jerry-skydio jerry-skydio deleted the jerry/revup/main/win branch October 11, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants