Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend: Don't attempt to lookup topics if no github remote #80

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

jerry-skydio
Copy link
Collaborator

If we're in a repo with no remote, or no github remote, don't
attempt the topics lookup at all as we assume the user isn't
using "revup upload" in this repo.

This slightly speeds up and avoids some errors.

Topic: amend_lookup
Reviewers: brian-k

If we're in a repo with no remote, or no github remote, don't
attempt the topics lookup at all as we assume the user isn't
using "revup upload" in this repo.

This slightly speeds up and avoids some errors.

Topic: amend_lookup
Reviewers: brian-k
@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
#80 amend: Don't attempt to lookup topics if no github remote

@jerry-skydio
Copy link
Collaborator Author

# head base diff date summary
0 5a5366d6 311ff10d diff Oct 24 17:41 PM 3 files changed, 51 insertions(+), 40 deletions(-)

@jerry-skydio jerry-skydio merged commit dd7fbf3 into main Jan 11, 2023
@jerry-skydio jerry-skydio deleted the jerry/revup/main/amend_lookup branch January 11, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants