DCP206202: Update Function Template #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndreRodriguesSkyline
commented
Apr 19, 2023
AndreRodriguesSkyline
commented
- Add Functions file with some pre-populated content
- Profile Definition JSON file will be generated when creating the solution
- Profile-load script now has some initial code
- Add Definitions/Instances/Parameters sub-folders to the Profile Data folder
- Add Functions file with some pre-populated content - Generated profile definition json - Profile-load script now has some initial code - Add Definitions/Instances/Parameters sub-folders to Profile Data folder
working/templates/srmfunction/.template_config/dotnetcli.host.json
Outdated
Show resolved
Hide resolved
| @@ -11,6 +11,9 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Newtonsoft.Json"> | |||
| <Version>13.0.2</Version> | |||
| </PackageReference> | |||
| <PackageReference Include="Skyline.DataMiner.Dev.Automation"> | |||
There was a problem hiding this comment.
Currently the code does not compile, I suppose the SRM nuget will get added here?
There was a problem hiding this comment.
Yes, currently the code doesn't compile.
I was waiting for the SRM nugget to add it here. If you prefer we can meanwhile add the DLL here.
PedroDebevere
approved these changes
May 8, 2023
AndreRodriguesSkyline
changed the title
There was a problem hiding this comment.
Looks good. Maybe the dev/QA can be continued when the nuget package is there.
Some small remarks:
- Is there a specific reason to rename to readme files to about.md?
Maybe use capitals for the file name because that's more common. - Not related (but annoying): the gitignore in root is missing out on .vs in de subfolders
- The user symbol now shows "skyline2" by default. That'll be confusing for users imo. Use "domain\username" instead?
working/templates/srmfunction/.template_config/dotnetcli.host.json
Outdated
Show resolved
Hide resolved
| <Name>$PROTOCOLNAME$</Name> | ||
| </Protocol> | ||
| <Function id="$FUNCTIONID$" name="$FUNCTIONNAME$" maxInstances="0" profile="$PROFILEDEFINITIONID$"> | ||
| </Function> |
There was a problem hiding this comment.
S: Include some examples for parameters, interfaces, graphical tags. Can be commented out.
There was a problem hiding this comment.
The function file only needs the Id and profile Id to allow the user to make use of the function editor in DIS.
The idea is to use DIS to extend the function, so no need to insert examples...
|
- Remove extra comma - Fix guids to match solution file - Specify the required fields
working/templates/srmfunction/Profile Data/Definitions/ProfileDefinitionName.json
Outdated
Show resolved
Hide resolved
slc-peter-vanpoucke
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.