[KOA-4846] Fixed white spaces selection in calendar component #2296
Conversation
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers, |
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2296 to see this build running in a browser. |
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2296 to see this build running in a browser. |
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2296 to see this build running in a browser. |
anambl
changed the title
| ignoreOutsideDate, | ||
| ) { | ||
| const { startDate, endDate } = selectionConfiguration; | ||
| const sameStartDay = isSameDay(date, startDate); |
There was a problem hiding this comment.
We might want to check if startDate and endDate are available before calling these functions as it can sometimes throw errors that they are not available when calling the isSameDay functions - can we check it just to make sure?
I know this was something that came up during the original build of the code
There was a problem hiding this comment.
good point! I'll check this!
There was a problem hiding this comment.
It seems like it should be alright as the function returns false if one or both dates are null 🤔
| ignoreOutsideDate && | ||
| rangeDates && | ||
| isSameMonth(startDate, endDate) && | ||
| isWithinRange(date, { start: startDate, end: endDate }) && |
| !isSameMonth(startDate, endDate) && | ||
| !isSameMonth(month, date) && | ||
| ((isSameWeek(date, endDate, { weekStartsOn }) && | ||
| isAfter(date, startDate)) || |
|
Also sorry I didn't mean to use request changes but comment instead 😂 |
Remember to include the following changes:
UNRELEASED.md(See How to write a good changelog entry)README.md