[NO JIRA]: Fix incorrect custom prop type in calendar #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers, |
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2308 to see this build running in a browser. |
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2308 to see this build running in a browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue whereby the custom
SelectionConfigurationprop type was failing due to incorrect typing oftypevariable in the object. This change correctly types the field to use a specific value as per theprop-typesspec.Which would throw a console error in the browser of
Warning: Failed prop type: checker is not a functionRemember to include the following changes:
UNRELEASED.md(See How to write a good changelog entry)