Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOA-4848] Update padding in input and textarea components #2309

Merged
merged 6 commits into from
Dec 9, 2021

Conversation

anambl
Copy link
Contributor

@anambl anambl commented Dec 8, 2021

Before After
image image
+ large textarea example image image

Summary:

  • Add large property to textarea component
  • Update left and right padding in input and textarea components to 0.5rem for default size and 1rem when large prop is true
  • When input/textarea is valid/invalid/clearable, set right padding to 2rem and 2.5rem when large (left padding in RTL) to account for the valid/invalid/clearable icons.

Remember to include the following changes:

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Visit https://backpack.github.io/storybook-prs/2309 to see this build running in a browser.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers,
particularly IE11.

Generated by 🚫 dangerJS against 11d5d6f

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Visit https://backpack.github.io/storybook-prs/2309 to see this build running in a browser.

@anambl anambl marked this pull request as ready for review December 9, 2021 09:03
@olliecurtis olliecurtis merged commit ce955d6 into main Dec 9, 2021
@olliecurtis olliecurtis deleted the KOA-4848 branch December 9, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants