Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARGG-927][BpkBreakpoint] Update breakpoint to remove hydration mismatch error #3169

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

anambl
Copy link
Contributor

@anambl anambl commented Jan 16, 2024

Fix hydration mismatch error in BpkBreakpoint component. This change makes the BpkBreakpoint server-side snapshot match the snapshot initially rendered on the client.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@anambl anambl added the patch Patch production bug label Jan 16, 2024
Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against bb3150b

Copy link

Visit https://backpack.github.io/storybook-prs/3169 to see this build running in a browser.

@@ -16,7 +16,7 @@
* limitations under the License.
*/

import type { ReactNode } from 'react';
import { useState, type ReactNode, useEffect } from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never knew you could inline type imports 🤯

Copy link
Contributor

@metalix2 metalix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anambl anambl merged commit 18aa5a0 into main Jan 16, 2024
10 checks passed
@anambl anambl deleted the ARGG-27 branch January 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants