Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backpack-web]: Revert CSS layers due to incompatibility with supported browsers #3210

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

olliecurtis
Copy link
Member

This change reverts our recent efforts with CSS layers #3119 as we found that it is incompatible with Safari versions 15.4 and below which is below our current supported range, and causes issues with functionality in use.

We will re-review the approach post this reversion on how we can progress forward with mitigation CSS issues

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@olliecurtis olliecurtis added the patch Patch production bug label Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Visit https://backpack.github.io/storybook-prs/3210 to see this build running in a browser.

Copy link
Contributor

@alakbarz alakbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimming over the 250 changes, it looks good to me.

@olliecurtis olliecurtis merged commit 773b1e5 into main Feb 2, 2024
10 checks passed
@olliecurtis olliecurtis deleted the no-jira-revert-css-layers branch February 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants