-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COR-481][BpkDrawer] Update backpack drawer to tsx #3667
Merged
Parisistan
merged 10 commits into
Skyscanner:main
from
TristanGrayCC:NOJIRA_update_drawer_to_tsx
Nov 13, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f18cd3b
Update BpkJourneyArrow.module.scss
4d59409
Merge branch 'main' into COR-251-arrow-responsive-rendering
olliecurtis 6d7735a
Update drawer to tsx
45d61f6
Update BpkJourneyArrow.module.scss
5684626
Merge branch 'main' into NOJIRA_update_drawer_to_tsx
57e52db
Update BpkDrawer.tsx
54918bb
Update BpkDrawerContent.tsx
270ff2e
Importing types for drawer
15f9c3e
Type imports updated
fe1ef40
Drawer snapshot update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/* | ||
* Backpack - Skyscanner's Design System | ||
* | ||
* Copyright 2016 Skyscanner Ltd | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
/* @flow strict */ | ||
|
||
import type { ReactNode } from 'react'; | ||
import { useState } from 'react'; | ||
|
||
import { Portal, isDeviceIphone } from '../../bpk-react-utils'; | ||
import { withScrim } from '../../bpk-scrim-utils'; | ||
|
||
import BpkDrawerContent from './BpkDrawerContent'; | ||
|
||
const BpkScrimDrawerContent = withScrim(BpkDrawerContent); | ||
|
||
export type Props = { | ||
id: string, | ||
children: ReactNode; | ||
isOpen: boolean, | ||
onClose?: ( | ||
arg0?: TouchEvent | MouseEvent | KeyboardEvent, | ||
arg1?: { | ||
source: 'ESCAPE' | 'DOCUMENT_CLICK'; | ||
}, | ||
) => void; | ||
title: string, | ||
getApplicationElement: () => HTMLElement | null, | ||
renderTarget?: null | HTMLElement | (() => null | HTMLElement), | ||
dialogRef?: (ref: HTMLElement | null | undefined) => void, | ||
className?: string | null, | ||
contentClassName?: string, | ||
closeLabel?: string | null, | ||
closeText?: string, | ||
hideTitle?: boolean, | ||
isIphone?: boolean, | ||
padded?: boolean, | ||
}; | ||
|
||
const BpkDrawer = ({ | ||
children, | ||
className = null, | ||
closeLabel = null, | ||
closeText = undefined, | ||
contentClassName = undefined, | ||
dialogRef, | ||
getApplicationElement, | ||
hideTitle = false, | ||
id, | ||
isIphone = isDeviceIphone(), | ||
isOpen, | ||
onClose, | ||
padded = true, | ||
renderTarget = null, | ||
title, | ||
}: Props) => { | ||
|
||
const [isDrawerShown, setIsDrawerShown] = useState(true); | ||
|
||
const onCloseAnimationComplete = () => { | ||
if (onClose){ | ||
onClose(); | ||
} | ||
}; | ||
|
||
const hide = () => { | ||
setIsDrawerShown(false) | ||
}; | ||
|
||
return( | ||
<Portal isOpen={isOpen} onClose={hide} renderTarget={renderTarget}> | ||
<BpkScrimDrawerContent | ||
id={id} | ||
title={title} | ||
dialogRef={dialogRef} | ||
closeLabel={closeLabel || ""} | ||
closeText={closeText} | ||
additionalClassName={className} | ||
contentClassName={contentClassName} | ||
getApplicationElement={getApplicationElement} | ||
hideTitle={hideTitle} | ||
isDrawerShown={isDrawerShown} | ||
onClose={hide} | ||
onCloseAnimationComplete={onCloseAnimationComplete} | ||
closeOnScrimClick | ||
isIpad | ||
isIphone={isIphone} | ||
padded={padded} | ||
> | ||
{children} | ||
</BpkScrimDrawerContent> | ||
</Portal> | ||
); | ||
} | ||
|
||
export default BpkDrawer; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being ON-IT with comments. 🙂