Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA][BpkAccordion]: Fix flow types in BpkAccordion #3674

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

xalechez
Copy link
Contributor

@xalechez xalechez commented Nov 22, 2024

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copy link

Visit https://backpack.github.io/storybook-prs/3674 to see this build running in a browser.

Copy link

github-actions bot commented Nov 22, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 5e40255

@olliecurtis
Copy link
Member

Could we just do the better thing here and convert to TS? Solves two problems:

  • Using flow
  • Migrates another component to TS (the ultimate goal)

@xalechez xalechez added the patch Patch production bug label Nov 25, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3674 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3674 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3674 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3674 to see this build running in a browser.

@xalechez xalechez merged commit 5c3bfec into main Nov 25, 2024
9 checks passed
@xalechez xalechez deleted the fix-flow-types branch November 25, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants