-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[choreo] Adds CLI support for generating trajectories #602
Conversation
Added the ability to open Choroe by doing I also overhauled the Tauri Commands to make them more isolated and reduce the reliance on absolute paths in the frontend. More work still needs to be done on the frontend to make it follow this paradigm |
src/components/field/svg/constraintDisplay/FieldConstraintAddLayer.tsx
Outdated
Show resolved
Hide resolved
src/components/field/svg/constraintDisplay/FieldConstraintDisplayLayer.tsx
Show resolved
Hide resolved
src/document/DocumentManager.ts
Outdated
if (traj) { | ||
await Commands.renameTraj(traj.serialize, newName) | ||
.then((new_traj) => { | ||
doc.pathlist.addPath(newName, true, new_traj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do with the old path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is just deleting the old one from the pathlist appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don’t see the benefit of deleting and tea-adding over just changing the name. For one thing, you won’t be able to keep the same waypoint selected through the delete and readd
src/document/tauriTracing.ts
Outdated
* @param optionalParams Additional parameters to be logged. | ||
*/ | ||
export function TraceError(message: any, ...optionalParams: any[]): void { | ||
console.log(message, optionalParams); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be console.error
Choreo CLI
Usage: Choreo [OPTIONS]
Options:
-h, --help Print help
-V, --version Print version
File Options:
--chor <path/to/myproject.chor>
--traj <trajName1,trajName2> Adds trajectories to be used by cli actions
--all-traj The same as doing --traj for all trajectories in the project
Action Options:
-g, --generate Generate the provided trajectories for the project
Advanced Options:
-f, --free Free the process to run in another process and return immediately
--ipc <IPC> A serialized IPC handle to the parent process 2024-08-29.13-44-56.mp4 |
This PR broke for me when generating a trajectory with two waypoints in the GUI. I get the following error and no trajectory.
|
May be a linux only issue? 2024-09-01.17-41-09.mp4 |
The only thing left in this pr that's blatantly non-functional is frontend tracing locations on webkit |
Closes #36
Not a final implementation
If no args are provided it will launch GUI despite what help says
right now you need a
--chor
, at least 1--traj
and-g
for it to do anything