Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and simplify continuous integration #136

Closed
jcfr opened this issue Aug 13, 2021 · 2 comments · Fixed by #137
Closed

Fix and simplify continuous integration #136

jcfr opened this issue Aug 13, 2021 · 2 comments · Fixed by #137

Comments

@jcfr
Copy link
Member

jcfr commented Aug 13, 2021

As of August 13th 2021, all jobs are failing:

image

Source: https://app.circleci.com/pipelines/github/Slicer/SlicerExecutionModel/19/workflows/ed1fad58-f7e9-4df7-8887-ddf82dd7e454

Suggested plan:

  • Remove these obsolete jobs:

    SlicerExecutionModel/.circleci/config.yml

    Lines 56 to 58 in f19d6e8

    - itk-v4.8.0_use_system_libraries-off
    - itk-v4.10.1_use_system_libraries-off
    - itk-v4.13.0_use_system_libraries-off

  • Update itk-master_use_system_libraries-off docker image

  • Add itk-v5.1.2_use_system_libraries-off and itk-v5.2.1_use_system_libraries-off

For more details:
@hjmjohnson
Copy link
Member

Is this still outstanding?

@jcfr jcfr linked a pull request Feb 10, 2022 that will close this issue
Fix continuous integration #137
Merged
@jcfr jcfr closed this as completed in #137 Feb 10, 2022
@jcfr
Copy link
Member Author

jcfr commented Feb 10, 2022

Is this still outstanding?

Indeed, it needed to be address. This ended up being more time consuming than anticipated.

@hjmjohnson hjmjohnson mentioned this issue Jun 2, 2022
Merged
@hjmjohnson hjmjohnson mentioned this issue Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix continuous integration jcfr/SlicerExecutionModel
2 participants
@jcfr @hjmjohnson