Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continuous integration #137

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Fix continuous integration #137

merged 4 commits into from
Feb 10, 2022

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Feb 10, 2022

@jcfr jcfr linked an issue Feb 10, 2022 that may be closed by this pull request
Fix and simplify continuous integration #136
Closed
@jcfr jcfr force-pushed the 136-fix-continuous-integration branch from 218054d to 0419f97 Compare February 10, 2022 19:33
@jcfr
Copy link
Member Author

jcfr commented Feb 10, 2022 •
edited
Loading

@hjmjohnson Look like there are issues building against the latest ITK.

In file included from ModuleDescriptionParser/ModuleDescriptionParser.cxx:24

/usr/local/include/ITK-5.3/expat.h:44:10: fatal error: expat_external.h: No such file or directory

 #include "expat_external.h"
          ^~~~~~~~~~~~~~~~~~
compilation terminated.

See https://slicer.cdash.org/viewBuildError.php?buildid=2587288

@jcfr
Copy link
Member Author

jcfr commented Feb 10, 2022 •
edited
Loading

Build options to build ITK are the following:

image
Source: https://github.com/jcfr/SlicerExecutionModel/blob/0419f97ea9587b6b858f2a94a7d7df71d66eac0a/test/Docker-ITK-master_USE_SYSTEM_LIBRARIES-OFF/Dockerfile#L24-L37

@jcfr jcfr mentioned this pull request Feb 10, 2022
Merged
2 tasks
@jcfr jcfr merged commit 18c872d into Slicer:master Feb 10, 2022
@jcfr jcfr deleted the 136-fix-continuous-integration branch February 10, 2022 21:15
dzenanz pushed a commit to InsightSoftwareConsortium/ITK that referenced this pull request Feb 14, 2022
@jcfr @dzenanz
COMP: Fix build against ITK install adding "expat_external.h" install…
1f7b427 
… rule

This commit fixes a regression introduced in 9e337d3 (ENH: Update expat
files) by pull request #2755 on 2021-09-27.

ITK issue is #3186 and problem was first documented in
Slicer/SlicerExecutionModel#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and simplify continuous integration
1 participant
@jcfr