Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix Issue #15: acceptEndorsement now returns a value #16

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

BugFix Issue #15: acceptEndorsement now returns a value #16

wants to merge 1 commit into from

Conversation

akshayarora2009
Copy link

This commit adds some potential error handling, and also returns true from the function acceptEndorsement.

@SmartIdentity SmartIdentity deleted a comment from andylockran Sep 19, 2017
@dci-aloughran
Copy link
Contributor

Please can you approve you agree with the contributor's license, then I can merge.

Thanks,

Andy Loughran

dci-aloughran
dci-aloughran requested changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@dci-aloughran dci-aloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add a test for each of the states before I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dci-aloughran dci-aloughran dci-aloughran requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshayarora2009 @dci-aloughran