-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override child profiles for lights and plugs only #1874
base: main
Are you sure you want to change the base?
Override child profiles for lights and plugs only #1874
Conversation
Invitation URL: |
Test Results 64 files 406 suites 0s ⏱️ Results for commit 56da529. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 56da529 |
can we make a unit test or two for this? seems like a worthwhile thing to make sure it doesn't break |
ff83f6a
to
17e146a
Compare
Yeah good call - I updated a mock device in |
17e146a
to
4e98553
Compare
Devices that utilize the child_device_profile_overrides table may contain other endpoints that should not have their profile overridden when the child device is created.
4e98553
to
56da529
Compare
Type of Change
Checklist
Description of Change
Devices that utilize the child_device_profile_overrides table may contain other endpoints that should not have their profile overridden when the child device is created. This PR ensures that the profile is only overridden for light and plug child device types. See the discussion from PR 1872.
Note that
GENERIC_SWITCH_ID
was removed fromdevice_type_profile_map
. This is because it is never used in this table and also to make it clear that device types in this table may have their child device profile overridden (buttons do not use parent-child).Summary of Completed Tests