Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: expose a lot of typings #96

Merged
merged 4 commits into from
Aug 16, 2021
Merged

refactor: expose a lot of typings #96

merged 4 commits into from
Aug 16, 2021

Conversation

fdasfsafsa
Copy link
Contributor

Possibly breaking?

@fdasfsafsa fdasfsafsa requested a review from Snazzah as a code owner August 15, 2021 14:13
@Snazzah Snazzah added scope: types This has something to do with typings semver: major PRs that contain breaking changes and will be on the next major release labels Aug 15, 2021
Snazzah
Snazzah requested changes Aug 15, 2021
View reviewed changes
Copy link
Owner

@Snazzah Snazzah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might as well be a breaking change.

Also DeepScan is conflicting with Prettier, so don't worry about that error.

Changes

  • RequestHandler -> ServerRequestHandler
  • TypedEmitter -> TypedEventEmitter
  • FLAGS constants from Permissions and UserFlags are hidden

src/server.ts Outdated Show resolved Hide resolved
src/util/bitfield.ts Outdated Show resolved Hide resolved
@Snazzah Snazzah merged commit 9d3f4a3 into Snazzah:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snazzah Snazzah Snazzah requested changes

Assignees
No one assigned
Labels
scope: types This has something to do with typings semver: major PRs that contain breaking changes and will be on the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdasfsafsa @Snazzah