Introduce Commands and CommandHandler in the StreamingJobMaintenanceService #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging job-command-handlers into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
s-vitaliy
changed the title
|
Coverage after merging job-command-handlers into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
adelinag08
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47
This Pull Request changes how the
StreamingJobMaintenanceServicehandles Job update events. In previous versions of the code, theOnJobEventmethod that handles Job events performed invocations of dependent services to run actions in response to Job events. This led to code maintainability problems: if handling an event requires any additional context, we need to chain tasks deeply in the event handler.Now, this service only converts the job events into instances of the
KubernetesCommandclass, without requesting any context using asynchronous methods. The actual handling of these events is performed by implementations of theICommandHandlerinterface that are injected into this service.This PR is the first in series of pull requests related to event handlers refactoring.
Scope
Implemented:
KubernetesCommandand it's implementationsSetAnnotationCommand,StreamingJobCommandandUpdateStatusCommandAdditional changes:
Deconstructmethod for theIStreamDefinitioninterface for pattern matching.OnJobAddedhandler since we don't use it.Checklist
latestcommit.