Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify project structure #85

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Unify project structure #85

merged 4 commits into from
Jun 7, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented May 23, 2024 •
edited
Loading

Part of #45

Scope

Implemented:

  • Unify the project structure
  • Update the Readme.md

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@github-actions GitHub Actions
Copy link

Coverage after merging unify-project-structure into main will be

78.80%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Configurations
   MetricsPublisherActorConfiguration.cs100%100%100%100%
   MetricsReporterConfiguration.cs100%100%100%100%
src/Extensions
   JsonElementExtensions.cs0%100%0%0%23, 31
   KubernetesCommandExtensions.cs100%100%100%100%
   KubernetesObjectExtensions.cs0%100%0%0%15–18
   StreamClassPhaseExtensions.cs100%100%100%100%
   V1JobExtensions.cs82.24%63.64%94.12%89.01%105, 105, 126, 126, 131, 136, 136, 141, 146, 146, 151, 53, 53, 58, 68, 68, 75, 83–84, 84, 84, 84, 84–87
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs100%100%100%100%
src/Models/Commands
   StreamClassCommands.cs100%100%100%100%
   StreamDefinitionCommands.cs84.62%100%85.71%84%63–65, 91
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs68.75%66.67%75%68.52%39–42, 54–57, 64–67, 74–80
   StreamingJobCommandHandler.cs81.93%80%100%81.16%104–106, 47, 57, 66–69, 80–85
   UpdateStatusCommandHandler.cs90.91%75%100%91.18%100–101, 44–47, 83
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs85.29%100%75%85.71%50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs100%100%100%100%
src/Services/Operators
   StreamClassOperatorService.cs80.56%50%83.33%84.48%102–104, 104, 104–109, 81, 81, 85
   StreamingJobOperatorService.cs90.60%83.33%100%92.59%116–120, 125, 129, 134, 75, 75, 79
   StreamOperatorService.cs80%68.97%90.91%83.56%101–105, 148–149, 149, 149, 151–152, 161–162, 172–177, 195, 197, 201, 201, 207, 209, 70–71, 71, 71–72, 85–86, 86, 86, 86, 86, 86, 86–89, 91
src/Services/Repositories/CustomResources
   StreamClassRepository.cs100%100%100%100%
   StreamDefinitionRepository.cs0%100%0%0%20–23, 28–35, 39–44
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–48
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

s-vitaliy added 3 commits June 6, 2024 13:23
@s-vitaliy
Merge branch 'main' into unify-project-structure
bd097ce 
# Conflicts:
#	src/Services/Base/CommandHandlers/IStreamingJobCommandHandler.cs
@s-vitaliy
Merge main branch and update readme
360fa7c
@s-vitaliy
Self-reveiw fix
965e4fa
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Coverage after merging unify-project-structure into main will be

78.67%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Configurations
   MetricsPublisherActorConfiguration.cs100%100%100%100%
   MetricsReporterConfiguration.cs100%100%100%100%
src/Extensions
   KubernetesCommandExtensions.cs100%100%100%100%
   KubernetesObjectExtensions.cs100%100%100%100%
   StreamClassPhaseExtensions.cs100%100%100%100%
   V1JobExtensions.cs82.24%63.64%94.12%89.01%105, 105, 126, 126, 131, 136, 136, 141, 146, 146, 151, 53, 53, 58, 68, 68, 75, 83–84, 84, 84, 84, 84–87
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs100%100%100%100%
src/Models/Commands
   StreamClassCommands.cs100%100%100%100%
   StreamDefinitionCommands.cs84.62%100%85.71%84%63–65, 91
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs73.24%66.67%100%72.13%39–42, 59–62, 71–74, 81–87
   StreamingJobCommandHandler.cs84.51%80%100%84.48%47, 57, 67–72, 91–93
   UpdateStatusCommandHandler.cs91.14%75%100%91.43%102–103, 44–47, 85
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs85.29%100%75%85.71%50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs57.14%25%66.67%58.14%42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95
src/Services/Operators
   StreamClassOperatorService.cs93.06%62.50%100%96.55%104, 106, 81, 81, 85
   StreamingJobOperatorService.cs90.60%83.33%100%92.59%116–120, 125, 129, 134, 75, 75, 79
   StreamOperatorService.cs80.37%68.97%90.91%84.14%101–105, 148–149, 149, 149, 151–152, 161, 171–176, 194, 196, 200, 200, 206, 208, 70–71, 71, 71–72, 85–86, 86, 86, 86, 86, 86, 86–89, 91
src/Services/Repositories/CustomResources
   StreamClassRepository.cs100%100%100%100%
   StreamDefinitionRepository.cs0%100%0%0%20–23, 28–35, 39–44
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–48
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Coverage after merging unify-project-structure into main will be

78.42%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Configurations
   MetricsPublisherActorConfiguration.cs100%100%100%100%
   MetricsReporterConfiguration.cs100%100%100%100%
src/Extensions
   KubernetesCommandExtensions.cs100%100%100%100%
   KubernetesObjectExtensions.cs100%100%100%100%
   StreamClassPhaseExtensions.cs100%100%100%100%
   V1JobExtensions.cs82.24%63.64%94.12%89.01%105, 105, 126, 126, 131, 136, 136, 141, 146, 146, 151, 53, 53, 58, 68, 68, 75, 83–84, 84, 84, 84, 84–87
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs100%100%100%100%
src/Models/Commands
   StreamClassCommands.cs100%100%100%100%
   StreamDefinitionCommands.cs84.62%100%85.71%84%63–65, 91
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs73.24%66.67%100%72.13%39–42, 59–62, 71–74, 81–87
   StreamingJobCommandHandler.cs81.69%70%100%82.76%47, 51, 54, 57, 67–72, 91–93
   UpdateStatusCommandHandler.cs91.14%75%100%91.43%102–103, 44–47, 85
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs85.29%100%75%85.71%50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs57.14%25%66.67%58.14%42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95
src/Services/Operators
   StreamClassOperatorService.cs93.06%62.50%100%96.55%104, 106, 81, 81, 85
   StreamingJobOperatorService.cs90.60%83.33%100%92.59%116–120, 125, 129, 134, 75, 75, 79
   StreamOperatorService.cs80.37%68.97%90.91%84.14%101–105, 148–149, 149, 149, 151–152, 161, 171–176, 194, 196, 200, 200, 206, 208, 70–71, 71, 71–72, 85–86, 86, 86, 86, 86, 86, 86–89, 91
src/Services/Repositories/CustomResources
   StreamClassRepository.cs92.86%50%100%95.45%31, 33
   StreamDefinitionRepository.cs0%100%0%0%20–23, 28–35, 39–44
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–48
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

@s-vitaliy s-vitaliy marked this pull request as ready for review June 6, 2024 12:30
@s-vitaliy s-vitaliy requested a review from a team as a code owner June 6, 2024 12:30
@s-vitaliy s-vitaliy changed the title Unify project structure for the Arcane service Unify project structure Jun 6, 2024
@s-vitaliy s-vitaliy merged commit 80dbb86 into main Jun 7, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the unify-project-structure branch June 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinag08 adelinag08 adelinag08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-vitaliy @adelinag08