Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus empty fork fix #132

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Nexus empty fork fix #132

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4116dc8
Nexus empty fork fix
henrikfoss Dec 20, 2024
64dc7a1
Update forked_algorithm.py
henrikfoss Dec 20, 2024
d9aaa9b
Update forked_algorithm.py
henrikfoss Dec 20, 2024
d0e2d6b
Merge branch 'main' into empty_forks_fix
henrikfoss Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions esd_services_api_client/nexus/algorithms/forked_algorithm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,6 @@ async def _measured_run(**run_args) -> AlgorithmResult:
self._get_forks, **self._inputs, **kwargs
)()

if len(forks) > 0:
self._logger.info(
"Forking node with: {forks}, after the node run",
forks=",".join([fork.alias() for fork in forks]),
)
else:
self._logger.info("Leaf algorithm node: proceeding with this node run only")

run_result = await partial(
_measured_run,
**kwargs,
Expand All @@ -170,7 +162,15 @@ async def _measured_run(**run_args) -> AlgorithmResult:
logger=self._logger,
)()

# now await callback scheduling
await asyncio.wait([asyncio.create_task(fork.run(**kwargs)) for fork in forks])
if len(forks) > 0:
self._logger.info(
"Forking node with: {forks}, after the node run",
forks=",".join([fork.alias() for fork in forks]),
)
await asyncio.wait(
[asyncio.create_task(fork.run(**kwargs)) for fork in forks]
)
else:
self._logger.info("Leaf algorithm node: proceeding with this node run only")

return run_result