Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom resources to crystal configuration #14

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Sep 22, 2022

Fixes SneaksAndData/crystal#94

Scope

Implemented:

  • Added custom_resources to AlgorithmConfiguration

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Pylint 10.0/10.0 without bloating .pylintrc with exceptions.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner September 22, 2022 12:12
@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/arcane
   __init__.py220%5–6
   _connector.py59590%4–158
   _models.py95950%4–191
esd_services_api_client/beast
   _auth.py271833%18–19, 27–31, 39–48, 57–63
   _connector.py695619%29–36, 39–53, 56–82, 93–131, 142–171
   _models.py1102082%41–42, 149–152, 161–169, 179–186, 194–197
esd_services_api_client/boxer
   __init__.py220%5–6
   _auth.py25250%5–52
   _connector.py58580%4–116
   _helpers.py14140%3–31
   _models.py32320%4–97
esd_services_api_client/crystal
   _connector.py693943%27–41, 50, 64–67, 75, 83, 86, 89, 103–122, 131–140, 149–156, 166–179, 200
TOTAL69442039% 

Tests Skipped Failures Errors Time
9 0 💤 0 ❌ 0 🔥 1.049s ⏱️

@s-vitaliy s-vitaliy merged commit c0a8ffa into main Sep 22, 2022
@s-vitaliy s-vitaliy deleted the add_custom_resources_to_crystal_client branch September 22, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants