Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crystal connector to work with v2 API #75

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

george-zubrienko
Copy link
Contributor

Adds v1-compatible support for Crystal v2.

Scope

Implemented:

  • Replaced base_url with scheduler_base_url and receiver_base_url. This will work with v1 out of box, but will require a client upgrade.

Checklist

  • Unit tests added and they pass.
  • Pylint 10.0/10.0 without bloating .pylintrc with exceptions.

@george-zubrienko george-zubrienko requested a review from a team as a code owner October 25, 2023 19:05
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v2
   _connector.py856326%54–69, 76, 79–97, 117–154, 166–210, 218, 243–246, 256–288
   _models.py1082081%58–62, 167–170, 179–187, 197–205, 213–216
esd_services_api_client/beast/v3
   _connector.py926925%58–73, 80, 83–101, 121–156, 169–201, 209, 234–237, 248–266, 276–282
   _models.py1052972%46–50, 54, 59–60, 70–76, 108–111, 120–128, 138–146, 154–157
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py874944%74–78, 86–90, 97–100, 107–111, 118–121, 128–131, 139–142, 149–152, 160, 170–176, 190–199, 209–214
   _helpers.py141029%27–33, 40–46
   _models.py37684%37, 49, 70, 82, 103, 115
esd_services_api_client/crystal
   _connector.py1165057%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–296, 320, 332–342
tests
   test_crystal_connector.py88199%51
TOTAL94131467% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 14.392s ⏱️

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v2
   _connector.py856326%54–69, 76, 79–97, 117–154, 166–210, 218, 243–246, 256–288
   _models.py1082081%58–62, 167–170, 179–187, 197–205, 213–216
esd_services_api_client/beast/v3
   _connector.py926925%58–73, 80, 83–101, 121–156, 169–201, 209, 234–237, 248–266, 276–282
   _models.py1052972%46–50, 54, 59–60, 70–76, 108–111, 120–128, 138–146, 154–157
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py874944%74–78, 86–90, 97–100, 107–111, 118–121, 128–131, 139–142, 149–152, 160, 170–176, 190–199, 209–214
   _helpers.py141029%27–33, 40–46
   _models.py37684%37, 49, 70, 82, 103, 115
esd_services_api_client/crystal
   _connector.py1175057%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–296, 320, 332–342
tests
   test_crystal_connector.py88199%51
TOTAL94231467% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.910s ⏱️

@george-zubrienko george-zubrienko merged commit d88b10c into main Oct 26, 2023
@george-zubrienko george-zubrienko deleted the crystal-v2 branch October 26, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants