Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boxer claims support #81

Merged
merged 10 commits into from
Dec 8, 2023
Merged

Add boxer claims support #81

merged 10 commits into from
Dec 8, 2023

Conversation

adelinag08
Copy link
Contributor

@adelinag08 adelinag08 commented Dec 4, 2023

Part of https://github.com/SneaksAndData/snd-cli/issues/17

Scope

Implemented:

  • Add requests to Boxer claim endpoints (get claims, insert claim, remove claim, add user, delete user)

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Pylint 10.0/10.0 without bloating .pylintrc with exceptions.
  • Review requested on latest commit.

Copy link

github-actions bot commented Dec 4, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v2
   _connector.py896527%54–70, 77, 89, 97–115, 135–172, 184–228, 236, 261–264, 274–306
   _models.py1082081%58–62, 167–170, 179–187, 197–205, 213–216
esd_services_api_client/beast/v3
   _connector.py1078025%58–74, 81, 93, 101–119, 139–174, 187–219, 227, 252–255, 262–265, 276–294, 304–310, 319–325
   _models.py1022972%46–50, 54, 59–60, 70–76, 108–111, 120–128, 138–146, 154–157
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1175057%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–296, 320, 332–342
tests
   test_crystal_connector.py88199%51
TOTAL93631466% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.928s ⏱️

Copy link

github-actions bot commented Dec 4, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v2
   _connector.py896527%54–70, 77, 89, 97–115, 135–172, 184–228, 236, 261–264, 274–306
   _models.py1082081%58–62, 167–170, 179–187, 197–205, 213–216
esd_services_api_client/beast/v3
   _connector.py1078025%58–74, 81, 93, 101–119, 139–174, 187–219, 227, 252–255, 262–265, 276–294, 304–310, 319–325
   _models.py1022972%46–50, 54, 59–60, 70–76, 108–111, 120–128, 138–146, 154–157
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1165057%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–296, 320, 332–342
tests
   test_crystal_connector.py88199%51
TOTAL93531466% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.783s ⏱️

@adelinag08 adelinag08 marked this pull request as ready for review December 5, 2023 12:46
@adelinag08 adelinag08 requested a review from a team as a code owner December 5, 2023 12:46
Copy link
Contributor

@george-zubrienko george-zubrienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Copy link
Contributor

@george-zubrienko george-zubrienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after this one

@adelinag08 adelinag08 merged commit 1904b05 into main Dec 8, 2023
@adelinag08 adelinag08 deleted the boxer-claims-support branch December 8, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants