Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V2 as V3 is now GA #84

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Remove V2 as V3 is now GA #84

merged 1 commit into from
Dec 14, 2023

Conversation

george-zubrienko
Copy link
Contributor

Closes #82

Scope

Implemented:

  • Removed deprecated v2 code and ironed out some API inconsistencies

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Pylint 10.0/10.0 without bloating .pylintrc with exceptions.

@george-zubrienko george-zubrienko requested a review from a team as a code owner December 13, 2023 17:04
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v3
   _connector.py1078025%58–74, 81, 93, 101–119, 139–174, 187–218, 226, 251–254, 261–264, 275–292, 302–308, 317–323
   _models.py1002080%46–50, 107–110, 119–127, 137–145, 153–156
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1175057%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–296, 320, 332–342
tests
   test_crystal_connector.py88199%51
TOTAL73522070% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.321s ⏱️

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v3
   _connector.py1078025%58–74, 81, 93, 101–119, 139–174, 187–218, 226, 251–254, 261–264, 275–292, 302–308, 317–323
   _models.py1002080%46–50, 107–110, 119–127, 137–145, 153–156
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1165057%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–296, 320, 332–342
tests
   test_crystal_connector.py88199%51
TOTAL73422070% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.241s ⏱️

@george-zubrienko george-zubrienko merged commit f126131 into main Dec 14, 2023
@george-zubrienko george-zubrienko deleted the remove-bv2 branch December 14, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BeastJobParams inconsistent with V3 API
2 participants