Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable payload injection in MLA Framework #86

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Enable payload injection in MLA Framework #86

merged 7 commits into from
Jan 18, 2024

Conversation

george-zubrienko
Copy link
Contributor

Part of #83

Scope

Implemented:

  • Enabled payload injection via inject library using dynamic bind call
  • Added payload reader that supports async read and deser from the payload uri provided from CLI args

Checklist

  • GitHub issue exists for this change.
  • Pylint 10.0/10.0 without bloating .pylintrc with exceptions.

@george-zubrienko george-zubrienko requested a review from a team as a code owner January 17, 2024 14:10
Copy link

github-actions bot commented Jan 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v3
   _connector.py1078025%58–74, 81, 93, 101–119, 139–174, 187–218, 226, 251–254, 261–264, 275–292, 302–308, 317–323
   _models.py1002080%46–50, 107–110, 119–127, 137–145, 153–156
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1195256%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–292, 320, 332–342
esd_services_api_client/nexus/abstractions
   logger_factory.py16160%20–58
   nexus_object.py20200%21–61
   socket_provider.py12120%4–46
esd_services_api_client/nexus/algorithms
   __init__.py330%20–22
   _baseline_algorithm.py15150%21–56
   distributed.py14140%21–53
   minimalistic.py10100%20–44
   recursive.py18180%21–58
esd_services_api_client/nexus/core
   app_core.py1051050%20–259
   app_dependencies.py70700%20–199
esd_services_api_client/nexus/exceptions
   __init__.py110%20
   _nexus_error.py220%21–27
   input_reader_error.py15150%20–51
   startup_error.py14140%21–48
esd_services_api_client/nexus/input
   __init__.py220%21–22
   input_processor.py39390%20–88
   input_reader.py37370%20–104
   payload_reader.py33330%20–83
tests
   test_crystal_connector.py88199%51
TOTAL116364844% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.621s ⏱️

Copy link

github-actions bot commented Jan 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
esd_services_api_client/beast/v3
   _connector.py1078025%58–74, 81, 93, 101–119, 139–174, 187–218, 226, 251–254, 261–264, 275–292, 302–308, 317–323
   _models.py1002080%46–50, 107–110, 119–127, 137–145, 153–156
esd_services_api_client/boxer
   _auth.py861780%42–43, 52–61, 70–76, 87
   _connector.py895044%54–58, 64–68, 74–76, 82–84, 92–99, 107–113, 121–128, 136–144, 179, 189–195, 209–218, 228–233
   _models.py27293%49–50
esd_services_api_client/crystal
   _connector.py1185256%54–66, 75, 147, 150, 169–196, 208, 217, 238, 243–254, 273–292, 320, 332–342
esd_services_api_client/nexus/abstractions
   logger_factory.py16160%20–58
   nexus_object.py20200%21–61
   socket_provider.py12120%4–46
esd_services_api_client/nexus/algorithms
   __init__.py330%20–22
   _baseline_algorithm.py15150%21–56
   distributed.py14140%21–53
   minimalistic.py10100%20–44
   recursive.py18180%21–58
esd_services_api_client/nexus/core
   app_dependencies.py70700%20–199
esd_services_api_client/nexus/exceptions
   __init__.py110%20
   _nexus_error.py220%21–27
   input_reader_error.py15150%20–51
   startup_error.py14140%21–48
esd_services_api_client/nexus/input
   __init__.py220%21–22
   input_reader.py37370%20–104
   payload_reader.py33330%20–83
tests
   test_crystal_connector.py88199%51
TOTAL101850450% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 13.608s ⏱️

Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

@george-zubrienko george-zubrienko merged commit f3da744 into main Jan 18, 2024
3 checks passed
@george-zubrienko george-zubrienko deleted the mla-001 branch January 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants