-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcontroller.go
739 lines (644 loc) · 31.2 KB
/
controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
/*
* Copyright (c) 2024. ECCO Data & AI Open-Source Project Maintainers.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package main
import (
"context"
"fmt"
"github.com/DataDog/datadog-go/v5/statsd"
v1 "github.com/SneaksAndData/nexus-core/pkg/apis/science/v1"
"github.com/SneaksAndData/nexus-core/pkg/generated/clientset/versioned/scheme"
"github.com/SneaksAndData/nexus-core/pkg/shards"
"github.com/SneaksAndData/nexus-core/pkg/telemetry"
"golang.org/x/time/rate"
corev1 "k8s.io/api/core/v1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
"k8s.io/apimachinery/pkg/util/wait"
coreinformers "k8s.io/client-go/informers/core/v1"
"k8s.io/client-go/kubernetes"
typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
corelisters "k8s.io/client-go/listers/core/v1"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
"k8s.io/client-go/util/workqueue"
"k8s.io/klog/v2"
"reflect"
"time"
clientset "github.com/SneaksAndData/nexus-core/pkg/generated/clientset/versioned"
nexusscheme "github.com/SneaksAndData/nexus-core/pkg/generated/clientset/versioned/scheme"
nexusinformers "github.com/SneaksAndData/nexus-core/pkg/generated/informers/externalversions/science/v1"
nexuslisters "github.com/SneaksAndData/nexus-core/pkg/generated/listers/science/v1"
)
const (
// ReconcileLatencyMetric name for statsd
ReconcileLatencyMetric = "reconcile_latency"
// WorkqueueLengthMetric name for statsd
WorkqueueLengthMetric = "workqueue_length"
)
const controllerAgentName = "nexus-configuration-controller"
const (
// SuccessSynced is used as part of the Event 'reason' when a MachineLearningAlgorithm is synced
SuccessSynced = "Synced"
// ErrResourceExists is used as part of the Event 'reason' when a MachineLearningAlgorithm fails
// to sync due to one of: MLA CR, Secret owned by MLA CR, ConfigMap owned by MLA CR of the same name already existing.
ErrResourceExists = "ErrResourceExists"
// ErrResourceMissing is used as part of the Event 'reason' when a MachineLearningAlgorithm fails
// to sync due to a Secret or a ConfigMap referenced by it is missing from the controller cluster
ErrResourceMissing = "ErrResourceMissing"
// ErrResourceSyncError is used when a secret/configmap fails to sync with a fatal exception
ErrResourceSyncError = "ErrResourceSyncError"
// MessageResourceExists is the message used for Events when a resource
// fails to sync due to one of: MLA CR, Secret owned by MLA CR, ConfigMap owned by MLA CR already existing
MessageResourceExists = "Resource %q already exists and is not managed by any Machine Learning Algorithm"
// MessageResourceSynced is the message used for an Event fired when a MachineLearningAlgorithm
// is synced successfully
MessageResourceSynced = "Machine Learning Algorithm synced successfully"
// MessageResourceMissing is the message used for an Event fired when a MachineLearningAlgorithm references a missing Secret or a ConfigMap
MessageResourceMissing = "Resource %q referenced by MachineLearningAlgorithm %q is missing in the controller cluster"
// MessageResourceOperationFailed is the message used for an Event fired in case of fatal exceptions occurring during Secret/Configmap sync
MessageResourceOperationFailed = "Synchronization/update of a resource %q referenced by MachineLearningAlgorithm %q failed with a fatal error %s"
// FieldManager distinguishes this controller from other things writing to API objects
FieldManager = controllerAgentName
)
// Controller is the controller implementation for MachineLearningAlgorithm resources
type Controller struct {
// controllerkubeclientset is a standard kubernetes clientset, for the cluster where controller is deployed
controllerkubeclientset kubernetes.Interface
// controllernexusclientset is a clientset for Machine Learning Algorithm API group, for the cluster where controller is deployed
controllernexusclientset clientset.Interface
nexusShards []*shards.Shard
// secretLister is a Secret lister in the cluster where controller is deployed
secretLister corelisters.SecretLister
secretsSynced cache.InformerSynced
// configMapLister is a ConfigMap lister in the cluster where controller is deployed
configMapLister corelisters.ConfigMapLister
configMapsSynced cache.InformerSynced
// mlaLister is a MachineLearningAlgorithm lister in the cluster where controller is deployed
mlaLister nexuslisters.MachineLearningAlgorithmLister
mlaSynced cache.InformerSynced
// workqueue is a rate limited work queue. This is used to queue work to be
// processed instead of performing it as soon as a change happens. This
// means we can ensure we only process a fixed amount of resources at a
// time, and makes it easy to ensure we are never processing the same item
// simultaneously in two different workers.
workqueue workqueue.TypedRateLimitingInterface[cache.ObjectName]
// recorder is an event recorder for recording Event resources to the
// Kubernetes API.
recorder record.EventRecorder
}
// enqueueMachineLearningAlgorithm takes a MachineLearningAlgorithm resource and converts it into a namespace/name
// string which is then put onto the work queue.
func (c *Controller) enqueueMachineLearningAlgorithm(obj interface{}) {
switch ot := obj.(type) {
case *v1.MachineLearningAlgorithm:
if objectRef, err := cache.ObjectToName(obj); err != nil {
utilruntime.HandleError(err)
return
} else {
c.workqueue.Add(objectRef)
}
default:
utilruntime.HandleError(fmt.Errorf("unsupported type passed into work queue: %s", ot))
return
}
}
// handleObject will take any resource implementing metav1.Object and attempt
// to find the MachineLearningAlgorithm resource that 'owns' it. It does this by looking at the
// objects metadata.ownerReferences field for an appropriate OwnerReference.
// It then enqueues that MachineLearningAlgorithm resource to be processed. If the object does not
// have an appropriate OwnerReference, it will simply be skipped.
func (c *Controller) handleObject(obj interface{}) {
var object metav1.Object
var ok bool
logger := klog.FromContext(context.Background())
// attempt to read the object metadata
if object, ok = obj.(metav1.Object); !ok {
// check if object was deleted while we were not watching by attempting to get its tombstone info
tombstone, deleted := obj.(cache.DeletedFinalStateUnknown)
if !deleted {
// If the object value is not too big and does not contain sensitive information then
// it may be useful to include it.
utilruntime.HandleErrorWithContext(context.Background(), nil, "Error decoding object, invalid type", "type", fmt.Sprintf("%T", obj))
return
}
// recover object data from the tombstone
object, ok = tombstone.Obj.(metav1.Object)
if !ok {
// If the object value is not too big and does not contain sensitive information then
// it may be useful to include it.
utilruntime.HandleErrorWithContext(context.Background(), nil, "Error decoding object tombstone, invalid type", "type", fmt.Sprintf("%T", tombstone.Obj))
return
}
logger.V(4).Info("Recovered deleted object", "resourceName", object.GetName())
}
switch object := object.(type) {
case *v1.MachineLearningAlgorithm:
logger.V(4).Info("MLA resource deleted, removing it from shards", "mla", klog.KObj(object))
for _, shard := range c.nexusShards {
deleteErr := shard.DeleteMachineLearningAlgorithm(object)
if deleteErr != nil {
utilruntime.HandleErrorWithContext(context.Background(), nil, "Error deleting MLA from a connected shard", "shard", shard.Name)
return
}
}
default:
logger.V(4).Info("Processing object", "object", klog.KObj(object))
if objRefs := object.GetOwnerReferences(); len(objRefs) > 0 {
for _, ownerRef := range objRefs {
if ownerRef.Kind != "MachineLearningAlgorithm" {
continue
}
mla, err := c.mlaLister.MachineLearningAlgorithms(object.GetNamespace()).Get(ownerRef.Name)
if err != nil {
logger.V(4).Info("Ignore orphaned object", "object", klog.KObj(object), "mla", ownerRef.Name)
return
}
c.enqueueMachineLearningAlgorithm(mla)
}
}
}
}
// NewController returns a new nexus-configuration-controller
func NewController(
ctx context.Context,
controllerNamespace string,
controllerKubeClientSet kubernetes.Interface,
controllerNexusClientSet clientset.Interface,
connectedShards []*shards.Shard,
controllerSecretInformer coreinformers.SecretInformer,
controllerConfigmapInformer coreinformers.ConfigMapInformer,
controllerMlaInformer nexusinformers.MachineLearningAlgorithmInformer,
failureRateBaseDelay time.Duration,
failureRateMaxDelay time.Duration,
rateLimitElementsPerSecond int,
rateLimitElementsBurst int) (*Controller, error) {
logger := klog.FromContext(ctx)
// Create event broadcaster
// Add nexus-configuration-controller types to the default Kubernetes Scheme so Events can be
// logged for nexus-configuration-controller types.
utilruntime.Must(nexusscheme.AddToScheme(scheme.Scheme))
logger.V(4).Info("Creating event broadcaster")
eventBroadcaster := record.NewBroadcaster(record.WithContext(ctx))
eventBroadcaster.StartStructuredLogging(0)
eventBroadcaster.StartRecordingToSink(&typedcorev1.EventSinkImpl{Interface: controllerKubeClientSet.CoreV1().Events(controllerNamespace)})
recorder := eventBroadcaster.NewRecorder(scheme.Scheme, corev1.EventSource{Component: controllerAgentName})
ratelimiter := workqueue.NewTypedMaxOfRateLimiter(
workqueue.NewTypedItemExponentialFailureRateLimiter[cache.ObjectName](failureRateBaseDelay, failureRateMaxDelay),
&workqueue.TypedBucketRateLimiter[cache.ObjectName]{Limiter: rate.NewLimiter(rate.Limit(rateLimitElementsPerSecond), rateLimitElementsBurst)},
)
controller := &Controller{
controllerkubeclientset: controllerKubeClientSet,
controllernexusclientset: controllerNexusClientSet,
nexusShards: connectedShards,
secretLister: controllerSecretInformer.Lister(),
secretsSynced: controllerSecretInformer.Informer().HasSynced,
configMapLister: controllerConfigmapInformer.Lister(),
configMapsSynced: controllerConfigmapInformer.Informer().HasSynced,
mlaLister: controllerMlaInformer.Lister(),
mlaSynced: controllerMlaInformer.Informer().HasSynced,
workqueue: workqueue.NewTypedRateLimitingQueue(ratelimiter),
recorder: recorder,
}
logger.Info("Setting up event handlers")
// Set up an event handler for when Machine Learning Algorithm resources change
_, handlerErr := controllerMlaInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: controller.enqueueMachineLearningAlgorithm,
UpdateFunc: func(old, new interface{}) {
controller.enqueueMachineLearningAlgorithm(new)
},
DeleteFunc: controller.handleObject,
})
if handlerErr != nil {
return nil, handlerErr
}
// This way, we don't need to implement custom logic for handling Secret/ConfigMap resources.
// More info on this pattern:
// https://github.com/kubernetes/community/blob/8cafef897a22026d42f5e5bb3f104febe7e29830/contributors/devel/controllers.md
// Set up an event handler for when Secret resources change. This
// handler will lookup the owner of the given Secret, and if it is
// owned by a MachineLearningAlgorithm resource then the handler will enqueue that
// MachineLearningAlgorithm resource for processing.
_, handlerErr = controllerSecretInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: controller.handleObject,
UpdateFunc: func(old, new interface{}) {
newSecret := new.(*corev1.Secret)
oldSecret := old.(*corev1.Secret)
if newSecret.ResourceVersion == oldSecret.ResourceVersion {
// Periodic resync will send update events for all known Secrets.
// Two different versions of the same Secret will always have different RVs.
return
}
controller.handleObject(new)
},
DeleteFunc: controller.handleObject,
})
if handlerErr != nil {
return nil, handlerErr
}
// Set up an event handler for when ConfigMap resources change. This
// handler will lookup the owner of the given ConfigMap, and if it is
// owned by a MachineLearningAlgorithm resource then the handler will enqueue that
// MachineLearningAlgorithm resource for processing.
_, handlerErr = controllerConfigmapInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: controller.handleObject,
UpdateFunc: func(old, new interface{}) {
newConfigMap := new.(*corev1.ConfigMap)
oldConfigMap := old.(*corev1.ConfigMap)
if newConfigMap.ResourceVersion == oldConfigMap.ResourceVersion {
// Periodic resync will send update events for all known ConfigMaps.
// Two different versions of the same ConfigMap will always have different RVs.
return
}
controller.handleObject(new)
},
DeleteFunc: controller.handleObject,
})
if handlerErr != nil {
return nil, handlerErr
}
return controller, nil
}
// runWorker is a long-running function that will continually call the
// processNextWorkItem function in order to read and process a message on the
// workqueue.
func (c *Controller) runWorker(ctx context.Context) {
for c.processNextWorkItem(ctx) {
}
}
// processNextWorkItem will read a single work item from the workqueue and
// attempt to process it, by calling the syncHandler.
func (c *Controller) processNextWorkItem(ctx context.Context) bool { // coverage-ignore
objRef, shutdown := c.workqueue.Get()
metrics := ctx.Value(telemetry.MetricsClientContextKey).(*statsd.Client)
itemProcessStart := time.Now()
if shutdown {
return false
}
// We call Done at the end of this func so the workqueue knows we have
// finished processing this item. We also must remember to call Forget
// if we do not want this work item being re-queued. For example, we do
// not call Forget if a transient error occurs, instead the item is
// put back on the workqueue and attempted again after a back-off
// period.
defer c.workqueue.Done(objRef)
defer telemetry.GaugeDuration(metrics, ReconcileLatencyMetric, itemProcessStart, []string{}, 1)
defer telemetry.Gauge(metrics, WorkqueueLengthMetric, float64(c.workqueue.Len()), []string{}, 1)
// Run the syncHandler, passing it the structured reference to the object to be synced.
err := c.syncHandler(ctx, objRef)
if err == nil {
// If no error occurs then we Forget this item so it does not
// get queued again until another change happens.
c.workqueue.Forget(objRef)
return true
}
// there was a failure so be sure to report it. This method allows for
// pluggable error handling which can be used for things like
// cluster-monitoring.
utilruntime.HandleErrorWithContext(ctx, err, "Error syncing; requeuing for later retry", "objectReference", objRef)
// since we failed, we should requeue the item to work on later. This
// method will add a backoff to avoid hotlooping on particular items
// (they're probably still not going to work right away) and overall
// controller protection (everything I've done is broken, this controller
// needs to calm down or it can starve other useful work) cases.
c.workqueue.AddRateLimited(objRef)
return true
}
func (c *Controller) reportMlaInitCondition(mla *v1.MachineLearningAlgorithm) (*v1.MachineLearningAlgorithm, error) {
// NEVER modify objects from the store. It's a read-only, local cache.
mlaCopy := mla.DeepCopy()
// init condition is only assigned to new resources
if len(mlaCopy.Status.Conditions) == 0 {
mlaCopy.Status.Conditions = []metav1.Condition{*v1.NewResourceReadyCondition(metav1.Now(), metav1.ConditionFalse, fmt.Sprintf("Algorithm %q initializing", mla.Name))}
return c.controllernexusclientset.ScienceV1().MachineLearningAlgorithms(mla.Namespace).UpdateStatus(context.TODO(), mlaCopy, metav1.UpdateOptions{FieldManager: FieldManager})
}
return mla, nil
}
func (c *Controller) reportMlaSyncedCondition(mla *v1.MachineLearningAlgorithm, updatedSecrets []string, updatedConfigMaps []string, shards []string) (*v1.MachineLearningAlgorithm, error) {
// NEVER modify objects from the store. It's a read-only, local cache.
mlaCopy := mla.DeepCopy()
// update conditions if changed
// later if multiple conditions are introduced this should compare possible sets of conditions to one another
// set time to prev instance first so DeepEqual can be used
newCondition := *v1.NewResourceReadyCondition(mlaCopy.Status.Conditions[0].LastTransitionTime, metav1.ConditionTrue, fmt.Sprintf("Algorithm %q ready", mla.Name))
mlaCopy.Status.Conditions[0] = newCondition
mlaCopy.Status.SyncedSecrets = updatedSecrets
mlaCopy.Status.SyncedConfigurations = updatedConfigMaps
mlaCopy.Status.SyncedToClusters = shards
if !reflect.DeepEqual(mla.Status, mlaCopy.Status) {
mlaCopy.Status.Conditions[0].LastTransitionTime = metav1.Now()
return c.controllernexusclientset.ScienceV1().MachineLearningAlgorithms(mla.Namespace).UpdateStatus(context.TODO(), mlaCopy, metav1.UpdateOptions{FieldManager: FieldManager})
}
return mla, nil
}
// isMissingOwnership checks if the resource is controlled by this MachineLearningAlgorithm resource,
// and if not AND the resource is not owned by any other MachineLearningAlgorithm, logs a warning to the event recorder and returns error msg.
func (c *Controller) isMissingOwnership(obj metav1.Object, owner metav1.Object) (bool, error) {
// if already controlled, no error
if objRefs := obj.GetOwnerReferences(); len(objRefs) > 0 {
// check if we own this object
// since secrets and configmaps can be referenced by multiple MLAs, we need to find `owner` there
for _, ownerRef := range obj.GetOwnerReferences() {
if ownerRef.Kind == "MachineLearningAlgorithm" && ownerRef.UID == owner.GetUID() {
return false, nil
}
}
} else {
// rogue resource not owned by any MachineLearningAlgorithm - report error
msg := fmt.Sprintf(MessageResourceExists, obj.GetName())
c.recorder.Event(obj.(runtime.Object), corev1.EventTypeWarning, ErrResourceExists, msg)
return false, fmt.Errorf("%s", msg)
}
return true, nil
}
func (c *Controller) syncSecretsToShard(secretNamespace string, controllerMla *v1.MachineLearningAlgorithm, shardMla *v1.MachineLearningAlgorithm, shard *shards.Shard, logger *klog.Logger) error {
for _, secretName := range shardMla.GetSecretNames() {
// Get the secret with the name specified in MachineLearningAlgorithm.spec
secret, err := c.secretLister.Secrets(secretNamespace).Get(secretName)
// If the referenced Secret resource doesn't exist in the cluster where the controller is deployed, update the syncErr and move on to the next Secret
if k8serrors.IsNotFound(err) { // coverage-ignore
msg := fmt.Sprintf(MessageResourceMissing, secretName, controllerMla.Name)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceMissing, msg)
logger.V(4).Info("Secret not found", "secretName", secretName, "shard", shard.Name)
return err
}
shardSecret, err := shard.SecretLister.Secrets(shardMla.Namespace).Get(secret.Name)
// secret does not exist in this shard, create it
if k8serrors.IsNotFound(err) {
shardSecret, err = shard.CreateSecret(shardMla, secret, FieldManager)
}
// requeue on error
if err != nil { // coverage-ignore
msg := fmt.Sprintf(MessageResourceOperationFailed, secretName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
missingOwner, err := c.isMissingOwnership(shardSecret, shardMla)
// requeue on error
if err != nil { // coverage-ignore
msg := fmt.Sprintf(MessageResourceOperationFailed, secretName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
// if Secret data differs, update the Secret
// if ownership is missing, update the Secret
if !reflect.DeepEqual(secret.Data, shardSecret.Data) {
logger.V(4).Info(fmt.Sprintf("Content changed for Secret %s, updating", secret.Name))
_, err = shard.UpdateSecret(shardSecret, secret.Data, nil, FieldManager)
// requeue on error
if err != nil {
msg := fmt.Sprintf(MessageResourceOperationFailed, secretName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
}
if missingOwner {
logger.V(4).Info(fmt.Sprintf("Ownership missing for Secret %s, updating", secret.Name))
_, err = shard.UpdateSecret(shardSecret, nil, shardMla, FieldManager)
// requeue on error
if err != nil {
msg := fmt.Sprintf(MessageResourceOperationFailed, secretName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
}
}
return nil
}
func (c *Controller) syncConfigMapsToShard(configMapNamespace string, controllerMla *v1.MachineLearningAlgorithm, shardMla *v1.MachineLearningAlgorithm, shard *shards.Shard, logger *klog.Logger) error {
for _, configMapName := range shardMla.GetConfigMapNames() {
// Get the ConfigMap with the name specified in MachineLearningAlgorithm.spec
configMap, err := c.configMapLister.ConfigMaps(configMapNamespace).Get(configMapName)
// If the referenced ConfigMap resource doesn't exist in the cluster where the controller is deployed, update syncErr and move on to the next ConfigMap
if k8serrors.IsNotFound(err) { // coverage-ignore
msg := fmt.Sprintf(MessageResourceMissing, configMapName, controllerMla.Name)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceMissing, msg)
logger.V(4).Info("ConfigMap not found", "configMapName", configMapName, "shard", shard.Name)
return err
}
shardConfigMap, err := shard.ConfigMapLister.ConfigMaps(shardMla.Namespace).Get(configMap.Name)
// secret does not exist in this shard, create it
if k8serrors.IsNotFound(err) { // coverage-ignore
shardConfigMap, err = shard.CreateConfigMap(shardMla, configMap, FieldManager)
}
// requeue on error
if err != nil { // coverage-ignore
msg := fmt.Sprintf(MessageResourceOperationFailed, configMapName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
missingOwner, err := c.isMissingOwnership(shardConfigMap, shardMla)
// requeue on error
if err != nil { // coverage-ignore
msg := fmt.Sprintf(MessageResourceOperationFailed, configMapName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
// if data differs, update
if !reflect.DeepEqual(configMap.Data, shardConfigMap.Data) {
logger.V(4).Info(fmt.Sprintf("Content changed for ConfigMap %s, updating", configMap.Name))
_, err = shard.UpdateConfigMap(shardConfigMap, configMap.Data, nil, FieldManager)
// requeue on error
if err != nil {
msg := fmt.Sprintf(MessageResourceOperationFailed, configMapName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
}
// if ownership is not set yet, update it
if missingOwner {
logger.V(4).Info(fmt.Sprintf("Ownership missing for ConfigMap %s, updating", configMap.Name))
_, err = shard.UpdateConfigMap(shardConfigMap, nil, shardMla, FieldManager)
// requeue on error
if err != nil {
msg := fmt.Sprintf(MessageResourceOperationFailed, configMapName, controllerMla.Name, err)
c.recorder.Event(controllerMla, corev1.EventTypeWarning, ErrResourceSyncError, msg)
return err
}
}
}
return nil
}
// shardNames returns names of all shards available for sync
func (c *Controller) shardNames() []string {
result := make([]string, 0, len(c.nexusShards))
for _, shard := range c.nexusShards {
result = append(result, shard.Name)
}
return result
}
func (c *Controller) isOwnedBy(obj metav1.ObjectMeta, controllerMla *v1.MachineLearningAlgorithm) bool {
for _, ownerRef := range obj.OwnerReferences {
if ownerRef.UID == controllerMla.UID {
return true
}
}
return false
}
func (c *Controller) adoptReferences(mla *v1.MachineLearningAlgorithm) error {
for _, secretName := range mla.GetSecretNames() {
referencedSecret, err := c.secretLister.Secrets(mla.Namespace).Get(secretName)
if err != nil {
c.recorder.Event(mla, corev1.EventTypeWarning, ErrResourceMissing, fmt.Sprintf(MessageResourceMissing, secretName, mla.Name))
return err
}
refCopy := referencedSecret.DeepCopy()
if !c.isOwnedBy(referencedSecret.ObjectMeta, mla) {
refCopy.OwnerReferences = append(refCopy.OwnerReferences, metav1.OwnerReference{
APIVersion: v1.SchemeGroupVersion.String(),
Kind: "MachineLearningAlgorithm",
Name: mla.Name,
UID: mla.UID,
})
_, err := c.controllerkubeclientset.CoreV1().Secrets(mla.Namespace).Update(context.TODO(), refCopy, metav1.UpdateOptions{})
if err != nil {
c.recorder.Event(mla, corev1.EventTypeWarning, ErrResourceSyncError, fmt.Sprintf(MessageResourceOperationFailed, secretName, mla.Name, err))
return err
}
}
}
for _, configMapName := range mla.GetConfigMapNames() {
referencedConfigMap, err := c.configMapLister.ConfigMaps(mla.Namespace).Get(configMapName)
if err != nil {
c.recorder.Event(mla, corev1.EventTypeWarning, ErrResourceMissing, fmt.Sprintf(MessageResourceMissing, configMapName, mla.Name))
return err
}
refCopy := referencedConfigMap.DeepCopy()
if !c.isOwnedBy(referencedConfigMap.ObjectMeta, mla) {
refCopy.OwnerReferences = append(refCopy.OwnerReferences, metav1.OwnerReference{
APIVersion: v1.SchemeGroupVersion.String(),
Kind: "MachineLearningAlgorithm",
Name: mla.Name,
UID: mla.UID,
})
_, err := c.controllerkubeclientset.CoreV1().ConfigMaps(mla.Namespace).Update(context.TODO(), refCopy, metav1.UpdateOptions{})
if err != nil {
c.recorder.Event(mla, corev1.EventTypeWarning, ErrResourceSyncError, fmt.Sprintf(MessageResourceOperationFailed, configMapName, mla.Name, err))
return err
}
}
}
return nil
}
// syncHandler compares the actual state with the desired, and attempts to
// converge the two. It then updates the Status block of the MachineLearningAlgorithm resource
// with the current status of the resource.
func (c *Controller) syncHandler(ctx context.Context, objectRef cache.ObjectName) error {
logger := klog.LoggerWithValues(klog.FromContext(ctx), "objectRef", objectRef)
// Get the MachineLearningAlgorithm resource with this namespace/name
logger.V(4).Info(fmt.Sprintf("Syncing algorithm %s", objectRef.Name))
mla, err := c.mlaLister.MachineLearningAlgorithms(objectRef.Namespace).Get(objectRef.Name)
if err != nil {
// The MachineLearningAlgorithm resource may no longer exist, in which case we stop
// processing.
if k8serrors.IsNotFound(err) {
utilruntime.HandleErrorWithContext(ctx, err, "MachineLearningAlgorithm referenced by item in work queue no longer exists", "objectReference", objectRef)
return nil
}
return err
}
mla, err = c.reportMlaInitCondition(mla)
// requeue in case status update fails
if err != nil {
return err
}
err = c.adoptReferences(mla)
// requeue in case we can't take ownership of referenced secrets/configs
if err != nil {
logger.V(4).Error(err, fmt.Sprintf("Invalid machine learning algorithm resource: %s", mla.Name))
return err
}
for _, shard := range c.nexusShards {
logger.V(4).Info(fmt.Sprintf("Syncing to shard %s", shard.Name))
shardMla, shardErr := shard.MlaLister.MachineLearningAlgorithms(objectRef.Namespace).Get(objectRef.Name)
// update this MLA in case it exists and has drifted
if shardErr == nil && !reflect.DeepEqual(shardMla.Spec, mla.Spec) {
logger.V(4).Info(fmt.Sprintf("Content changed for MachineLearningAlgorithm %s, updating", mla.Name))
shardMla, shardErr = shard.UpdateMachineLearningAlgorithm(shardMla, mla.Spec, FieldManager)
// requeue on error
if shardErr != nil {
return shardErr
}
}
// if MachineLearningAlgorithm has not been created yet, create a new one in this shard
if k8serrors.IsNotFound(shardErr) {
logger.V(4).Info(fmt.Sprintf("Algorithm %s not found in shard %s, creating", objectRef.Name, shard.Name))
shardMla, shardErr = shard.CreateMachineLearningAlgorithm(mla.Name, mla.Namespace, mla.Spec, FieldManager)
}
// requeue on error
if shardErr != nil {
logger.V(4).Error(shardErr, fmt.Sprintf("Error processing algorithm resource on shard %s", shard.Name))
return shardErr
}
logger.V(4).Info(fmt.Sprintf("Syncing secrets to shard %s", shard.Name))
shardErr = c.syncSecretsToShard(mla.Namespace, mla, shardMla, shard, &logger)
// requeue on error
if shardErr != nil {
logger.V(4).Error(shardErr, fmt.Sprintf("Error syncing secrets on shard %s", shard.Name))
return shardErr
}
logger.V(4).Info(fmt.Sprintf("Syncing configmaps to shard %s", shard.Name))
shardErr = c.syncConfigMapsToShard(mla.Namespace, mla, shardMla, shard, &logger)
// requeue on error
if shardErr != nil {
logger.V(4).Error(shardErr, fmt.Sprintf("Error syncing configMaps on shard %s", shard.Name))
return shardErr
}
}
// Finally, we update the status block of the MachineLearningAlgorithm resource in the controller cluster to reflect the
// current state of the world across all Shards
logger.V(4).Info(fmt.Sprintf("Processed all shards, updating status for %s", mla.Name))
mla, err = c.reportMlaSyncedCondition(mla, mla.GetSecretNames(), mla.GetConfigMapNames(), c.shardNames())
if err != nil {
logger.V(4).Error(err, "Error setting ready status condition")
return err
}
c.recorder.Event(mla, corev1.EventTypeNormal, SuccessSynced, MessageResourceSynced)
return nil
}
// Run will set up the event handlers for types we are interested in, as well
// as syncing informer caches and starting workers. It will block until stopCh
// is closed, at which point it will shutdown the workqueue and wait for
// workers to finish processing their current work items.
func (c *Controller) Run(ctx context.Context, workers int) error { // coverage-ignore
defer utilruntime.HandleCrash()
defer c.workqueue.ShutDown()
logger := klog.FromContext(ctx)
// Start the informer factories to begin populating the informer caches
logger.Info("Starting MachineLearningAlgorithm controller")
// Wait for the caches to be synced before starting workers
logger.Info("Waiting for informer caches to sync")
if ok := cache.WaitForCacheSync(ctx.Done(), c.secretsSynced, c.configMapsSynced, c.mlaSynced); !ok {
return fmt.Errorf("failed to wait for caches to sync")
}
logger.Info("Controller informers synced")
for _, shard := range c.nexusShards {
if ok := cache.WaitForCacheSync(ctx.Done(), shard.SecretsSynced, shard.ConfigMapsSynced, shard.MlaSynced); !ok {
return fmt.Errorf("failed to wait for shard %s caches to sync", shard.Name)
}
}
logger.Info("Shard informers synced")
logger.Info("Starting workers", "count", workers)
// Launch workers to process MachineLearningAlgorithm resources
for i := 0; i < workers; i++ {
go wait.UntilWithContext(ctx, c.runWorker, time.Second)
}
logger.Info("Started workers")
<-ctx.Done()
logger.Info("Shutting down workers")
return nil
}