Ignore AgentTransferFromNative bridge command #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may not be related to this PR but reminds me in V2, for transact, we allow the creation of a user/custom agent and dispatch transact with some Ether attached from that agent. So we may still need to allow the user to claim Ether from the agent. |
alistair-singh
added a commit
that referenced
this pull request
Jan 10, 2025
* do not dispatch transfer from native command * test to make sure the behavior is off * fmt * naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we now lock Ether in the agent, we should never allow transferring native Ether unless it is part of an unlock bridge command.
Resolves: https://linear.app/snowfork/issue/SNO-1222