refactor: contribution generic specific #6421

Viczei · 2025-01-15T11:39:48Z

No description provided.

…ric-specific

packages/code-du-travail-frontend/src/modules/contributions/ContributionGenericContent.tsx

carolineBda · 2025-01-20T10:00:09Z

...es/code-du-travail-frontend/src/modules/contributions/ContributionGenericAgreementSearch.tsx

+            alt="Personnalisez la réponse avec votre convention collective"
+            className={fr.cx("fr-unhidden-md", "fr-hidden")}
+          />
+          <span className={fr.cx("fr-h3", "fr-mt-1w", "fr-mb-1w")}>


Suggested change

<span className={fr.cx("fr-h3", "fr-mt-1w", "fr-mb-1w")}>

<p className={fr.cx("fr-h3", "fr-mt-1w")}>

packages/code-du-travail-frontend/src/modules/common/AccordionWithAnchor.tsx

...es/code-du-travail-frontend/src/modules/contributions/ContributionGenericAgreementSearch.tsx

packages/code-du-travail-frontend/cypress/integration/light/conventions-collectives.spec.ts

tokenbureau · 2025-01-21T09:55:37Z

🎉 Deployment for commit a42f3b3 :

Ingresses

🚀 https://code-du-travail-numerique-refactor-contribution-gener-koy36f1l.ovh.fabrique.social.gouv.fr/

Docker images

📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/code-du-travail-numerique/app:sha-a42f3b3515b699d12a5b910a2226286cc55046c4

Debug

* chore(dsfr): mise à jour de la version DSFR * fix(dsfr): ignore les exceptions d'hydratation * feat(tests): ajout du module de testing (#6096) * fix: tests * fix: tests * fix: command * fix: merge date * fix: tests * fix: tests * fix: tests * fix: tests * fix(dsfr): ignore les exceptions d'hydratation * fix: readme * feat(DSFR): migration de la page article du code du travail (#6099) * feat: 6093 dsfr page politique de confidentialit (#6094) * feat: implémentation page politique confidentialité dsfr * chore: clean * fix: iframe dark mode * chore: refacto + e2e test * feat: convert a to Link * chore: review * chore: rename test --------- Co-authored-by: victor <[email protected]> * feat(dsfr): ajout des liens d'évitement (#6120) * feat(dsfr): migration de la page plan du site (#6097) * feat(dsfr): mise à jour des snapshots * feat(dsfr): mise à jour des snapshots * chore(dsfr): mise à jour de la lib DSFR * feat(dsfr): ajout du composant "Avez-vous trouvé une réponse à votre question" (#6121) * fix: merge date * fix: satisfaction * fix: retours preavis * fix: retours preavis * fix: tests * move feedback component to the page articleCodeDuTravail.tsx * clean-up css * fix: feedback * fix: feedback * fix: tests * fix: tests * feat(dsfr): création du composant "Besoin de plus d'information" (#6135) * fix: ui * fix: composant --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * fix: retours * fix: tests * feat: nouvelle API pour les articles du code du travail (#6132) Co-authored-by: carolineBda <[email protected]> * fix(spec) : fix de la spec article-code-du-travail.spec.ts * fix(dsfr): ajout de la config pour supprimer le `insafe-inline` des `scripts` dans les `csp` (#6151) * feat(dsfr): ajout de matomo pour tracker les events (#6157) * fix: matomo * fix: matomo --------- Co-authored-by: Martial Maillot <[email protected]> * fix(feedback): ajout d'une logique de caractères restants (#6156) * fix: tests * feat: limiter à 500 caractères la saisie * feat: limiter à 500 caractères la saisie --------- Co-authored-by: Martial Maillot <[email protected]> * feat(dsfr): ajout du nouveau logo (#6159) * feat(dsfr): ajout des pages d'erreurs (404 + 500) (#6146) * fix: pages * fix: 404 * fix: tests * fix: tests * fix: tests * fix: lint * test error * fix errors * Fix spec * add button to test error page * feat: force error 500 for testing purpose * feat: revert errors --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * feat: séparation des anciennes API et des nouvelles (#6183) * fix(article code du travail): retrait du tag Code du travail (#6182) * feat(config): correction de `husky`, ajout de `prettier` pour le formattage et de `lint-staged` pour runner le formattage au `precommit` (#6192) * fix: prettier * fix: prettier * fix: readme * fix: readme * fix: bug * fix: prettier * fix: prettier * fix: tests * fix: tests * fix: prettier * fix: prettier * fix: branch * merge dev * feat: implémentation simulateur brut net * chore: fix ts * chore: snap * chore: clean * chore: clean * chore: clean * chore: review * feat: update responsive * Revert "Merge branch 'dev' into simulateur-brut-net-dsfr" This reverts commit 0748928, reversing changes made to cd15bc7. * chore: clean * feat: chore clean * chore: clean * chore: remove undesired files * chore: remove undesired files * chore: clean * feat: implementation page convention collective * feat: update button link * fix: meta description share * feat: switch simu brut net couleur par defaut * feat: ajout de l'icone * feat: update svg * fix: ts * fix: bug load * chore: review * fix: mobile display * chore: review * chore: review * chore: review * feat: implémentation trouver cc * feat: implementation trouver CC * chore: common style * feat: add error alert entreprise search * feat: disable card * feat: ajout TU + fix * chore: clean * fix: e2e tests * chore: clean * feat: implementation contribution dsfr * fix: widget * fix: error * feat: info bulle * fix: widget * fix: home fetch agreement * feat: add postmessage searchCC * fix: home cc * feat: change contenu lié search cc * fix: related items * fix: message erreur lors de la recherche * fix: error message * fix: relatedItems * chore: add TU * refactor: move files to folders * fix: build * chore: review * chore: clean * fix: ajout des canonicals * fix: input info * fix: canonicals * feat: ajout d'un spinner * fix: tests * chore: review * feat: add spinner to enterprise search * feat: contribution search cc * refactor: queries * fix: load on select item autocomplete * fix: bug widget selection entreprise * feat: implement alert message * fix: disabled rule * feat: localstorage * chore: review * chore: review * chore: review * chore: review * chore: review * chore: review * feat: implement content * chore: review * fix: garder la recherche entrerprise au click precedent * chore: review * chore: review * fix: TU + some styles * fix: e2e * refactor * fix: TU * fix: TU * chore: review * chore: review * chore: review * chore: review postalcode * chore: review * chore: review * fix: cypress test * chore: add widgetMode TU * chore: fix test * fix: cypress test * fix: cypress test * feat: implement * chore: cy * chore: fix cy * refactor * refactor * chore: review * chore: clean * chore: review * fix: largeur champs recherche entreprise * feat: ajout d'un message d'erreur pour les codes naf * feat: update design * chore: clean * feat: implement * chore: design review * chore: review * chore: test noindex * chore: nbsp * chore: review * chore: review * chore: fix test e2e * fix: previous * feat: implement input CC search form * fix: design * chore: clean * feat: ajout du localstorage * fix: bug recherche cc selectionne * fix: don't set cc for enterprise form * fix: localstorage wrong load * feat: add alert on CC select * fix: localstorage preload * fix: wrong slug * fix: goBack not removing cc * chore: review * chore: review * chore: TU * feat: add fiche SP * fix: design * feat: tracking * chore: TU fix * fix: cc entreprise select * feat: add tracking on radio agreement select * chore: tracking p1 et p2 * fix: doublon tracking * chore: snap * chore: review * fix: tracking event enterprise * fix: TU * fix: emit tracking enterprise recherche CC * chore: add TU tracking * feat: mise à jour design * fix(contributions): affichage du nom de la CC dans le H1 des contribs personnalisées (#6399) * fix: CC non traité message * fix: merge * refactor: contribution generic specific (#6421) * fix: texte CC non traité * refactor: division en plusieurs fichiers * refactor: typage * feat: ajout cas tests & correction message erreur cc non traité no CDT * chore: rename TU * feat: add TU non treated info description * fix: bug display 0 in middle of contribution * fix: design * chore: TU on 3239 * fix: TU * chore: review * fix: accordion collapse on anchor * fix: id no string * fix: broken link * fix: message warning non-treated agreement * fix: TU * fix: cc e2e tests * fix: accordion id * chore: review * chore: review * fix: regression number cc search * fix: localstorage * fix: review * refactor: isAgreementValid * chore: revert e2e deleted * refactor: clean --------- Co-authored-by: victor <[email protected]> * clean * clean * fix: add TU contribution content * fix: localstorage for enterprise search & noCdt description * refactor: localstorage * fix: margin references * fix: tracking on display button click * fix: radio unchecked by default * fix: localstorage should select radio * fix: design * fix: date mise à jour fiche SP * chore: add localstorage tests * refactor: localstorage should not send events * chore: snap * fix: review metier * fix: review code * fix: review code * refactor: use common link * chore: snap * clean up * fix url widget * lint * remove text when no CDT * fix related items * clean up types * try to fix spec * fix spec * fix snapshot * fix lien widget ! * add rules that are now valid * fix * feat: scroll to enterprise on selection * fix: TU * fix: scroll agreement modify * fix: list bullet truncate * fix: TU --------- Co-authored-by: Martial Maillot <[email protected]> Co-authored-by: Maxime Golfier <[email protected]> Co-authored-by: Victor Zeinstra <[email protected]> Co-authored-by: victor <[email protected]>

victor added 4 commits January 13, 2025 12:58

fix: texte CC non traité

3cc8a39

Merge branch '6233-contribution-dsfr' into refactor/contribution-gene…

de90802

…ric-specific

refactor: division en plusieurs fichiers

a8af618

Merge branch 'dev' into refactor/contribution-generic-specific

c62cbfe

Viczei requested review from m-maillot, carolineBda and maxgfr January 15, 2025 11:39

Viczei self-assigned this Jan 15, 2025

Viczei removed the request for review from maxgfr January 15, 2025 11:39

Viczei changed the base branch from dev to 6233-contribution-dsfr January 15, 2025 11:40

Merge branch '6233-contribution-dsfr' into refactor/contribution-gene…

4e3d6be

…ric-specific

Viczei temporarily deployed to review-auto January 15, 2025 11:50 — with GitHub Actions Inactive

Viczei had a problem deploying to review-auto January 15, 2025 15:25 — with GitHub Actions Failure

refactor: typage

47d7035

Viczei had a problem deploying to review-auto January 16, 2025 13:58 — with GitHub Actions Error

feat: ajout cas tests & correction message erreur cc non traité no CDT

54eb05a

Viczei had a problem deploying to review-auto January 16, 2025 14:00 — with GitHub Actions Error

chore: rename TU

6deb76f

Viczei had a problem deploying to review-auto January 16, 2025 14:07 — with GitHub Actions Error

feat: add TU non treated info description

409b09b

Viczei had a problem deploying to review-auto January 16, 2025 14:13 — with GitHub Actions Error

fix: bug display 0 in middle of contribution

30f08f9

Viczei temporarily deployed to review-auto January 16, 2025 14:16 — with GitHub Actions Inactive

fix: design

ef980a4

Viczei temporarily deployed to review-auto January 16, 2025 15:48 — with GitHub Actions Inactive

chore: TU on 3239

e83d6f0

Viczei temporarily deployed to review-auto January 20, 2025 08:36 — with GitHub Actions Inactive

fix: TU

a7d7e77

carolineBda reviewed Jan 20, 2025

View reviewed changes

packages/code-du-travail-frontend/src/modules/contributions/ContributionGenericContent.tsx Show resolved Hide resolved

carolineBda reviewed Jan 20, 2025

View reviewed changes

Viczei temporarily deployed to review-auto January 20, 2025 15:12 — with GitHub Actions Inactive

fix: TU

62fba72

Viczei temporarily deployed to review-auto January 20, 2025 15:40 — with GitHub Actions Inactive

fix: cc e2e tests

3adc0c8

carolineBda reviewed Jan 20, 2025

View reviewed changes

packages/code-du-travail-frontend/src/modules/common/AccordionWithAnchor.tsx Outdated Show resolved Hide resolved

Viczei temporarily deployed to review-auto January 20, 2025 15:51 — with GitHub Actions Inactive

fix: accordion id

9ec87ca

Viczei had a problem deploying to review-auto January 20, 2025 16:05 — with GitHub Actions Error

chore: review

48c6f15

Viczei temporarily deployed to review-auto January 20, 2025 16:07 — with GitHub Actions Inactive

chore: review

a33b639

carolineBda reviewed Jan 20, 2025

View reviewed changes

...es/code-du-travail-frontend/src/modules/contributions/ContributionGenericAgreementSearch.tsx Outdated Show resolved Hide resolved

Viczei temporarily deployed to review-auto January 20, 2025 17:22 — with GitHub Actions Inactive

fix: regression number cc search

d74caf9

Viczei temporarily deployed to review-auto January 20, 2025 18:05 — with GitHub Actions Inactive

fix: localstorage

0dc6cfd

Viczei temporarily deployed to review-auto January 21, 2025 08:48 — with GitHub Actions Inactive

fix: review

67ad158

Viczei temporarily deployed to review-auto January 21, 2025 09:46 — with GitHub Actions Inactive

refactor: isAgreementValid

a42f3b3

carolineBda reviewed Jan 21, 2025

View reviewed changes

packages/code-du-travail-frontend/cypress/integration/light/conventions-collectives.spec.ts Outdated Show resolved Hide resolved

Viczei had a problem deploying to review-auto January 21, 2025 10:35 — with GitHub Actions Error

chore: revert e2e deleted

9c8df50

Viczei had a problem deploying to review-auto January 21, 2025 10:38 — with GitHub Actions Failure

refactor: clean

198107c

Viczei merged commit c1b521b into 6233-contribution-dsfr Jan 21, 2025
19 of 20 checks passed

Viczei deleted the refactor/contribution-generic-specific branch January 21, 2025 10:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: contribution generic specific #6421

refactor: contribution generic specific #6421

Viczei commented Jan 15, 2025

carolineBda Jan 20, 2025

tokenbureau bot commented Jan 21, 2025

	<span className={fr.cx("fr-h3", "fr-mt-1w", "fr-mb-1w")}>
	<p className={fr.cx("fr-h3", "fr-mt-1w")}>

refactor: contribution generic specific #6421

refactor: contribution generic specific #6421

Conversation

Viczei commented Jan 15, 2025

carolineBda Jan 20, 2025

Choose a reason for hiding this comment

tokenbureau bot commented Jan 21, 2025