Fix wrong assets source #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
approved these changes
Aug 22, 2023
adagolodjo
pushed a commit
that referenced
this pull request
Dec 7, 2024
* Fix softprops/action-gh-release source from master to release branch. * Continue creation of release if there is faulty one build (macOS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates #83 into
master.The
softprops/action-gh-releaseGithub action used in the CI to deploy assets was incorrectly configured to themasterbranch (default behavior), instead of the current release set by thesofa_branchfield in thebuild-and-testmatrix.This lead to the following undesired behavior:
release-<version>) was incorrectly set tomasterbranch, which is invalid when current release is notmaster(such asv<version>).This PR also allow the creation of the release to continue on failure, which typically occurs if one asset is missing such the macOS archive as the macCI is down. Similarly to what has been proposed to SofaPython3, SoftRobots, STLIB, BeamAdapter and ModelOrderReduction plugins.