Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SofaBaseTopology module name and import path #136

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix SofaBaseTopology module name and import path #136

merged 1 commit into from
Dec 9, 2019

Conversation

jnbrunet
Copy link
Collaborator

@jnbrunet jnbrunet commented Dec 6, 2019

#108 changed the module name SofaBaseTopology to BaseTopology but did not propagate the change inside the init function of the module, which created a linked error when importing the module (I'm looking at you, @fredroy).

This PR fixes this, and also move the module into the Sofa package. Now, instead of doing

import BaseTopology

which doesn't make it clear that this is a Sofa package, you do:

from Sofa import BaseTopology

@damienmarchal
Copy link
Member

Thank @jnbrunet for the PR.
@marques-bruno can you look at it please (and the CI with the +2 failures)

@marques-bruno marques-bruno merged commit 1fc3356 into SofaDefrost:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants