-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised Inner Outer Inner mode for Classic mode #4417
Revised Inner Outer Inner mode for Classic mode #4417
Conversation
Nice! thx! |
@igiannakas |
The above is the same issue that Arachne used to have before the revisions in the inner/outer/inner ordering mode -> basically middle perimeters are on occasion drawn before the outer perimeter when there are multiple external perimeters on the same island. The revision enforces middle perimeters to be drawn after the external and if that is not possible it falls back to drawing the external perimeter first to minimise surface artefacts caused by the middle perimeter pushing out on the external ones if drawn first. Basically porting the below to classic mode and the fixes that came from those: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you
Ported the Arachne enhancements to inner-outer-inner wall ordering mode to Classic. It should behave better when multiple external perimeters are present in the same island and gracefully fall back to outer first to preserve wall consistency when inner-outer-inner wall ordering cannot be respected.
This brings feature parity between Arachne and Classic wall ordering for inner outer inner.