Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Current Plate with objects #5516

Closed

Conversation

eoyilmaz
Copy link
Contributor

@eoyilmaz eoyilmaz commented May 31, 2024

Description

Screenshots/Recordings/Graphs

Orca_Slicer_Duplicate_Plate_Preview_1.mp4

Tests

Run manual tests only...

@eoyilmaz eoyilmaz changed the title Duplicate Current Plate with object Duplicate Current Plate with objects May 31, 2024
@eoyilmaz
Copy link
Contributor Author

Oh, it is not properly working for one of my test scenes...

@eoyilmaz
Copy link
Contributor Author

Yes, I didn't think about the local transformations, need to do the transformation in global space.

@eoyilmaz
Copy link
Contributor Author

eoyilmaz commented Jun 1, 2024

Okay the local vs global transformation issue has been fixed now:

Orca_Slicer_Duplicate_Plate_Preview_2.mp4

And this is ready to be reviewed.

@eoyilmaz eoyilmaz force-pushed the 2025-plate_duplication_with_object branch from 97978fe to 933bd01 Compare June 1, 2024 18:48
@eoyilmaz
Copy link
Contributor Author

eoyilmaz commented Jun 7, 2024

Any progress with this PR?

@eoyilmaz eoyilmaz force-pushed the 2025-plate_duplication_with_object branch from 933bd01 to 6a6804d Compare June 14, 2024 10:24
@eoyilmaz
Copy link
Contributor Author

Tagging @SoftFever

@eoyilmaz
Copy link
Contributor Author

@SoftFever do you need any changes or any review comments?

@SoftFever
Copy link
Owner

Hi @eoyilmaz

Thank you for your time and effort.
After reviewing the use case, I feel it serves a very specific purpose that is unlikely to benefit other users. Therefore, I believe it's not a strong fit for the mainstream.

@techman83
Copy link

Interestingly, googling for this very use case led me to subscribing to this PR for updates. 🙂

@eoyilmaz
Copy link
Contributor Author

eoyilmaz commented Jul 1, 2024

Hi @eoyilmaz

Thank you for your time and effort. After reviewing the use case, I feel it serves a very specific purpose that is unlikely to benefit other users. Therefore, I believe it's not a strong fit for the mainstream.

Oh, okay, I used this functionality a lot in one of my last projects, where I had to print the same items in different color combinations, and because they were barely fitting to the built plate, placing them was not easy, duplicating the plate was much much easier.

Do you think that we can at least supply this functionality in the edit menu or in right-click context menu or somewhere else? Instead of placing it into the main toolbar and on the plate actions.

@PalyCGman
Copy link

I would very much appreciate if this "copy build plate" feature were implemented. Thanks

@SoftFever
Copy link
Owner

Hi @eoyilmaz
Thank you for your time and effort. After reviewing the use case, I feel it serves a very specific purpose that is unlikely to benefit other users. Therefore, I believe it's not a strong fit for the mainstream.

Oh, okay, I used this functionality a lot in one of my last projects, where I had to print the same items in different color combinations, and because they were barely fitting to the built plate, placing them was not easy, duplicating the plate was much much easier.

Do you think that we can at least supply this functionality in the edit menu or in right-click context menu or somewhere else? Instead of placing it into the main toolbar and on the plate actions.

Put it into Edit menu sounds feasible.

@SoftFever
Copy link
Owner

Seems this PR is currently inactive.
I'm closing it for now.
Please feel free to re-open it whenever you feel ready.
Thank you for your contribution!

@SoftFever SoftFever closed this Jul 23, 2024
@TylonHH
Copy link

TylonHH commented Aug 18, 2024

Please implement this feature

@eoyilmaz
Copy link
Contributor Author

eoyilmaz commented Sep 8, 2024

I updated my branch, so that the "Duplicate Current Plate" functionality now lives in the Edit menu, and removed the previously created actions in the plate actions and in the toolbar. I opted to keep the icons for future use.

@SoftFever, I can't re-open this PR, can help me with this?

Orca_Slicer_Duplicate_Plate_Preview_3_1.mp4

@SoftFever
Copy link
Owner

I updated my branch, so that the "Duplicate Current Plate" functionality now lives in the Edit menu, and removed the previously created actions in the plate actions and in the toolbar. I opted to keep the icons for future use.

@SoftFever, I can't re-open this PR, can help me with this?

Orca_Slicer_Duplicate_Plate_Preview_3_1.mp4

That's strange.
I can't reopen it either.
Looks like there is a forced pushing in this feature branch.
image

Can you create another PR instead?

@eoyilmaz
Copy link
Contributor Author

eoyilmaz commented Sep 9, 2024

Create #6710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants