Suppress some compiler warnings, fix few possible bugs. #6224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buzzhuzz
changed the title
|
Another candidate for suppression is |
Compilation of OrcaSlicer produces 3056 warnings. Nearly half of them related to unused functions and variables. It is unlikely we going to clean them up since we may want to keep code base as close to the BBS as possible
buzzhuzz
force-pushed
the
dbuzz/compiler-warnings
branch
from
286a34a to
445eba6
Compare
SoftFever
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suppress compiler warnings we not going to fix. Fix few obvious errors.
While looking at issue #6137 I found suspicious code:
OrcaSlicer/src/libslic3r/Extruder.cpp
Line 12 in 5e4dd4d
This led me to an idea that no one is looking at warnings produced by compilers.
Currently there are 3056 warnings emitted for OrcaSlicer build using GCC, nearly half of which are unused functions and variables. All that noise distracts developer making them completely ignore compiler output and because of this some obvious mistakes makes into the code base.