Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled dependency setting for filament and process #6235

Merged

Conversation

Azio-Pantheon
Copy link
Contributor

@Azio-Pantheon Azio-Pantheon commented Jul 23, 2024

Description

Enabled dependency setting for filament and process for Developer mode. Dependency feature seems to be commented out by BBS, this PR is just to uncommenting dependency tab related code. This fixes #1655 *This is probably not release-ready, but I want to share what I have.

Only changes I added were
from toggle_options();
to
if (m_active_page && !(m_active_page->title() == "Dependencies")) toggle_options();
This is necessary to prevent app crashing from viewing Dependency tab.

edit: also fixes #3497

Screenshots/Recordings/Graphs

You have to check the "Developer mode" box in the setting:
Screenshot 2024-07-23 131012

Then you can find the dependency tab for filament and process. It should work like it does in PrusaSlicer.
Screenshot 2024-07-23 131031
Screenshot 2024-07-23 131051

Tests

Community testers wanted.

It works for my personal use case(1 printer, multiple filaments and processes). I have not fully tested this feature like multiple printers. edge cases etc.

One issue I found: If a user deselects all dependencies for a filament or process, there is no way to set it back in OrcaSlicer. The profile for that filament or process is still in the configuration folder, you have to edit the json file to get it back. In PrusaSlicer, there is a "flag" toggle to show incompatible profiles, but I could not get this feature to work.
Screenshot 2024-07-23 132359

@tomlop33
Copy link

Hi,

This function will be added on the next version ?

@SwineFlew931
Copy link

SwineFlew931 commented Sep 7, 2024

@Azio-Pantheon Please help me out here. I installed the latest nightly build. Went to Preferences and checked Developer Mode. Have restarted Orca but do not get any Dependency Tabs. I'm willing to test and report. I have 4 printers, and two of them have Revo nozzle system, so I have multiple printer, process and filament profiles to test this on. I have been manually adding printer dependencies to the json files and this would make life soooo much easier.
Thanks in advance for any insight as to what I may have missed to get the tabs to show.

@Azio-Pantheon
Copy link
Contributor Author

@Azio-Pantheon Please help me out here. I installed the latest nightly build. Went to Preferences and checked Developer Mode. Have restarted Orca but do not get any Dependency Tabs. I'm willing to test and report. I have 4 printers, and two of them have Revo nozzle system, so I have multiple printer, process and filament profiles to test this on. I have been manually adding printer dependencies to the json files and this would make life soooo much easier. Thanks in advance for any insight as to what I may have missed to get the tabs to show.

Nightly build does not have this feature. Only merged features will be in the nightly build.

Only way you can have it is the developer way: clone the main branch to your local repo, and pull my changes in, then compile Orca on your own.

@florek41
Copy link

florek41 commented Sep 9, 2024

Definitely must have function! 👍

@SwineFlew931
Copy link

Thanks! I will do that ASAP.

@Azio-Pantheon Please help me out here. I installed the latest nightly build. Went to Preferences and checked Developer Mode. Have restarted Orca but do not get any Dependency Tabs. I'm willing to test and report. I have 4 printers, and two of them have Revo nozzle system, so I have multiple printer, process and filament profiles to test this on. I have been manually adding printer dependencies to the json files and this would make life soooo much easier. Thanks in advance for any insight as to what I may have missed to get the tabs to show.

Nightly build does not have this feature. Only merged features will be in the nightly build.

Only way you can have it is the developer way: clone the main branch to your local repo, and pull my changes in, then compile Orca on

@Azio-Pantheon Please help me out here. I installed the latest nightly build. Went to Preferences and checked Developer Mode. Have restarted Orca but do not get any Dependency Tabs. I'm willing to test and report. I have 4 printers, and two of them have Revo nozzle system, so I have multiple printer, process and filament profiles to test this on. I have been manually adding printer dependencies to the json files and this would make life soooo much easier. Thanks in advance for any insight as to what I may have missed to get the tabs to show.

Nightly build does not have this feature. Only merged features will be in the nightly build.

Only way you can have it is the developer way: clone the main branch to your local repo, and pull my changes in, then compile Orca on your own.

@Azio-Pantheon
Copy link
Contributor Author

One issue I found: If a user deselects all dependencies for a filament or process, there is no way to set it back in OrcaSlicer. The profile for that filament or process is still in the configuration folder, you have to edit the json file to get it back. In PrusaSlicer, there is a "flag" toggle to show incompatible profiles, but I could not get this feature to work.

I take this back. If a user deselects all dependencies, it defaults to "Select All." Dependency tab works perfectly fine without having the "flag"

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Azio-Pantheon
I am currently working on a feature to revamp a filament system, which includes re-enabling the profile dependency UI as part of it.
Your PR helps :)

@SoftFever SoftFever merged commit 4c955e5 into SoftFever:main Jan 13, 2025
16 checks passed
@SoftFever
Copy link
Owner

In the meantime, there are some UI glitches that need attention. For example, changing a value(e.g. tick the All checkbox) doesn't mark the preset as 'dirty,' and the 'All' checkbox status does not update correctly when we open the page again . I can investigate these issues, but if you're interested in taking a look, please let me know.

@Azio-Pantheon
Copy link
Contributor Author

In the meantime, there are some UI glitches that need attention. For example, changing a value(e.g. tick the All checkbox) doesn't mark the preset as 'dirty,' and the 'All' checkbox status does not update correctly when we open the page again . I can investigate these issues, but if you're interested in taking a look, please let me know.

Thanks for the update. Sure, I would love to investigate on these bugs when I'm less busy. I will keep an eye on bugs related to this pr.

GiacomoGuaresi pushed a commit to gingeradditive/OrcaSlicer that referenced this pull request Feb 8, 2025
* enabled dependency setting for filament and process

* Add information about inheritance back to Dependencies tab

* Merge pull request #1 from michmela44/Add_inherits_to_dependencies

Add information about inheritance back to Dependencies tab

* Merge branch 'main' into feature/enable_profile_dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants