Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar margin & spacing fixes #6238

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented Jul 24, 2024

Fixes unequal spacings and margins on sidebar

Used a class in Plater.cpp to control all spacings from a single file since sidebar is split to 3 files (ParamsPanel.cpp, Plater.cpp, Tab.cpp)

IMPORTANT CHANGES TO CHECK

This changes should be check on high res monitors
• Parameters body text alignment [src/slic3r/GUI/OG_CustomCtrl.cpp]
(https://github.com/SoftFever/OrcaSlicer/pull/6238/files#diff-7fcf2f61c2e06b7e6b295588e3d5039b11dd965ce2491568cc18ff94d3aabe9e)

Line 331 wxCoord h_pos = get_title_width() * m_em_unit + 4;

Titles drawn with StaticLine.cpp and it uses 18px for icon 5px for spacing. Spacing doesnt scales on messureSize()
This line controls alignment of body text on parameters. basically added 4 to fix misalignment. static line element on titlebar using +5 and it looks on on my 2K monitor.

NOTES

Type Spacing Description
Titlebar_Margin 8px Used as side margins on titlebar. Has less margin on sides to create separation with its content
Content_Margin 12px Used as side margins contents of title
Icon_Spacing 10px Used on main elements
Element_Spacing 5px Used if elements has relation between them like edit button for combo box etc.

Sidebar-spacings

EXISTING BUG

• Spacings changing on multiple filaments while it creating second row for that section. Its an existing bug

FIXES

• Most of spacings are not stantardised. Added a standart for them
• No spacing before Machine combo box and Bed type text
• No spacing between "Compare" and "View All Object Settings" icon
• Aligned Parameter texts to it's title text

COMPARISON

Before After
Screenshot-20240724144320 copyasdas

Before After
Screenshot-20240724141913 Screenshot-20240724144333

@yw4z
Copy link
Contributor Author

yw4z commented Feb 5, 2025

@Noisyfox @SoftFever this commit also done

only im not sure about how ths change shows on high dpi screens
[src/slic3r/GUI/OG_CustomCtrl.cpp]
Line 331 wxCoord h_pos = get_title_width() * m_em_unit + 4;
Titles drawn with StaticLine.cpp and it uses 18px for icon 5px for spacing. Spacing doesnt scales on messureSize()
So +4 shoudnt make any problem

@yw4z yw4z marked this pull request as ready for review February 5, 2025 00:17
@yw4z yw4z marked this pull request as draft February 8, 2025 01:09
@yw4z yw4z marked this pull request as ready for review February 8, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant